* Re: Bug in tdo24m [not found] <87972c700906230516n538ad959nbd4b1ea21943ffc2@mail.gmail.com> @ 2009-06-23 12:58 ` Richard Purdie 2009-06-29 1:40 ` Eric Miao 0 siblings, 1 reply; 3+ messages in thread From: Richard Purdie @ 2009-06-23 12:58 UTC (permalink / raw) To: Aviv Laufer; +Cc: eric.miao, linux-kernel Hi, On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote: > I have found a bug in tdo24m.c . > There is a call to kmalloc with the second param is sizeeof (flag) > instead of flag. > This cause a crash. Thats quite a nasty bug and its surprising its not been found before now! Can you resubmit the patch with description and most importantly a Signed-off-by line please (see Documentation/SubmittingPatches)? Cheers, Richard -- Richard Purdie Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug in tdo24m 2009-06-23 12:58 ` Bug in tdo24m Richard Purdie @ 2009-06-29 1:40 ` Eric Miao 2009-06-29 5:57 ` Aviv Laufer 0 siblings, 1 reply; 3+ messages in thread From: Eric Miao @ 2009-06-29 1:40 UTC (permalink / raw) To: Aviv Laufer; +Cc: Richard Purdie, eric.miao, linux-kernel Richard Purdie wrote: > Hi, > > On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote: >> I have found a bug in tdo24m.c . >> There is a call to kmalloc with the second param is sizeeof (flag) >> instead of flag. >> This cause a crash. > > Thats quite a nasty bug and its surprising its not been found before > now! Can you resubmit the patch with description and most importantly a > Signed-off-by line please (see Documentation/SubmittingPatches)? > Ooops - this is embarrassing, yet I didn't find this causing any crash by now, tdo24m works just OK on my Littleton and thus hiding this bug deeply. Aviv, Any update on this patch? I'd like to queue this ASAP. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug in tdo24m 2009-06-29 1:40 ` Eric Miao @ 2009-06-29 5:57 ` Aviv Laufer 0 siblings, 0 replies; 3+ messages in thread From: Aviv Laufer @ 2009-06-29 5:57 UTC (permalink / raw) To: Eric Miao; +Cc: Richard Purdie, eric.miao, linux-kernel Hi, I tested in on my PXA-270 board. The patch was submitted and I guess it's waiting for approval Aviv On Mon, Jun 29, 2009 at 4:40 AM, Eric Miao<eric.y.miao@gmail.com> wrote: > Richard Purdie wrote: >> Hi, >> >> On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote: >>> I have found a bug in tdo24m.c . >>> There is a call to kmalloc with the second param is sizeeof (flag) >>> instead of flag. >>> This cause a crash. >> >> Thats quite a nasty bug and its surprising its not been found before >> now! Can you resubmit the patch with description and most importantly a >> Signed-off-by line please (see Documentation/SubmittingPatches)? >> > > Ooops - this is embarrassing, yet I didn't find this causing any crash > by now, tdo24m works just OK on my Littleton and thus hiding this bug > deeply. > > Aviv, > > Any update on this patch? I'd like to queue this ASAP. > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-29 5:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87972c700906230516n538ad959nbd4b1ea21943ffc2@mail.gmail.com>
2009-06-23 12:58 ` Bug in tdo24m Richard Purdie
2009-06-29 1:40 ` Eric Miao
2009-06-29 5:57 ` Aviv Laufer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox