* Move of_node_to_nid to generic location
@ 2009-06-29 9:09 Michal Simek
2009-06-29 15:52 ` Grant Likely
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2009-06-29 9:09 UTC (permalink / raw)
To: Grant Likely, Arnd Bergmann, benh, Linux Kernel list,
David Miller, linux
Hi All,
I have on my list one task which needs to be discuss with you.
I look at of_node_to_nid for non NUMA systems. I think we should
move this function to asm-generic/topology.h.
This function is used for powerpc, sparc, microblaze (and maybe future arm?)
Arnd what do you think?
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Move of_node_to_nid to generic location
2009-06-29 9:09 Move of_node_to_nid to generic location Michal Simek
@ 2009-06-29 15:52 ` Grant Likely
2009-06-29 16:36 ` Arnd Bergmann
2009-06-29 20:14 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Grant Likely @ 2009-06-29 15:52 UTC (permalink / raw)
To: monstr; +Cc: Arnd Bergmann, benh, Linux Kernel list, David Miller, linux
On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
> Hi All,
>
> I have on my list one task which needs to be discuss with you.
> I look at of_node_to_nid for non NUMA systems. I think we should
> move this function to asm-generic/topology.h.
I'm in the process of moving a bunch of stuff out of the various
prom.c files and into drivers/of/*.c. If this is a common function,
then I think it should go there.
> This function is used for powerpc, sparc, microblaze (and maybe future arm?)
PowerPC uses it. Other than that I don't know.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Move of_node_to_nid to generic location
2009-06-29 15:52 ` Grant Likely
@ 2009-06-29 16:36 ` Arnd Bergmann
2009-06-29 20:14 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2009-06-29 16:36 UTC (permalink / raw)
To: Grant Likely; +Cc: monstr, benh, Linux Kernel list, David Miller, linux
On Monday 29 June 2009, Grant Likely wrote:
> On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
> > Hi All,
> >
> > I have on my list one task which needs to be discuss with you.
> > I look at of_node_to_nid for non NUMA systems. I think we should
> > move this function to asm-generic/topology.h.
>
> I'm in the process of moving a bunch of stuff out of the various
> prom.c files and into drivers/of/*.c. If this is a common function,
> then I think it should go there.
I agree, it fits better into one of the 'of' headers than the topology
header. Maybe include/linux/of_device.h or include/linux/of.h?
Arnd <><
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Move of_node_to_nid to generic location
2009-06-29 15:52 ` Grant Likely
2009-06-29 16:36 ` Arnd Bergmann
@ 2009-06-29 20:14 ` David Miller
2009-06-29 20:24 ` Michal Simek
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2009-06-29 20:14 UTC (permalink / raw)
To: grant.likely; +Cc: monstr, arnd, benh, linux-kernel, linux
From: Grant Likely <grant.likely@secretlab.ca>
Date: Mon, 29 Jun 2009 09:52:44 -0600
> On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
>> This function is used for powerpc, sparc, microblaze (and maybe future arm?)
>
> PowerPC uses it. Other than that I don't know.
Sparc64 definitely uses it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Move of_node_to_nid to generic location
2009-06-29 20:14 ` David Miller
@ 2009-06-29 20:24 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2009-06-29 20:24 UTC (permalink / raw)
To: David Miller; +Cc: grant.likely, arnd, benh, linux-kernel, linux
David Miller wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Mon, 29 Jun 2009 09:52:44 -0600
>
>> On Mon, Jun 29, 2009 at 3:09 AM, Michal Simek<monstr@monstr.eu> wrote:
>>> This function is used for powerpc, sparc, microblaze (and maybe future arm?)
>> PowerPC uses it. Other than that I don't know.
>
> Sparc64 definitely uses it.
of_node_nid is called from of_device_register function and could be used by all "fdt" arch.
Anyway I think that we found a solution for it.
Grant can you please incorporate this changes to your patches (just move implementation for non NUMA
systems)?
IMHO of_device.h is the best one.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-29 20:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-29 9:09 Move of_node_to_nid to generic location Michal Simek
2009-06-29 15:52 ` Grant Likely
2009-06-29 16:36 ` Arnd Bergmann
2009-06-29 20:14 ` David Miller
2009-06-29 20:24 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox