From: Jiri Slaby <jirislaby@gmail.com>
To: Daniel Ribeiro <drwyrm@gmail.com>
Cc: sameo@linux.intel.com, LKML <linux-kernel@vger.kernel.org>,
laforge@openezx.org
Subject: Re: MFD: mutex from ISR in ezx-pcap?
Date: Tue, 30 Jun 2009 00:11:05 +0200 [thread overview]
Message-ID: <4A493BF9.7010304@gmail.com> (raw)
In-Reply-To: <1246306840.18231.29.camel@brutus>
On 06/29/2009 10:20 PM, Daniel Ribeiro wrote:
> Em Seg, 2009-06-29 às 21:34 +0200, Jiri Slaby escreveu:
>> pcap_adc_irq tries to perform non-atomic operations in ISR which is not
>> allowed. Above that, it may deadlock.
>>
>> Since all the operations there (read, write, mutex locking) may sleep,
>> any objections to convert the ISR contents to a workqueue?
>
> pcap_adc_irq actually already runs from a workqueue (pcap_isr_work).
Aha, thanks, there is a specific irq handler. Ok, sounds fair.
But interrupts are disabled in pcap_isr_work anyway, so that
pcap_adc_irq shouldn't sleep, right? Or maybe I missed something again...
next prev parent reply other threads:[~2009-06-29 22:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 19:34 MFD: mutex from ISR in ezx-pcap? Jiri Slaby
2009-06-29 20:20 ` Daniel Ribeiro
2009-06-29 22:11 ` Jiri Slaby [this message]
2009-06-30 8:57 ` Daniel Ribeiro
2009-07-01 6:56 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A493BF9.7010304@gmail.com \
--to=jirislaby@gmail.com \
--cc=drwyrm@gmail.com \
--cc=laforge@openezx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox