From: Tejun Heo <tj@kernel.org>
To: Greg KH <greg@kroah.com>
Cc: David Miller <davem@davemloft.net>,
hancockr@shaw.ca, alan@lxorguk.ukuu.org.uk,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.ritz@gmx.ch, linux@dominikbrodowski.net,
kaneshige.kenji@jp.fujitsu.com, towerlexa@gmx.de,
benh@kernel.crashing.org, mingo@elte.hu, tglx@linutronix.de,
tony.luck@intel.com
Subject: Re: [RFC PATCH 1/2] pci: determine CLS more intelligently
Date: Tue, 30 Jun 2009 12:07:08 +0900 [thread overview]
Message-ID: <4A49815C.1080603@kernel.org> (raw)
In-Reply-To: <20090625173355.GA4847@kroah.com>
Greg KH wrote:
> On Thu, Jun 25, 2009 at 02:05:07AM -0700, David Miller wrote:
>> From: Tejun Heo <tj@kernel.org>
>> Date: Thu, 25 Jun 2009 16:12:13 +0900
>>
>>> sparc64 is currently the only one using PCI_CACHE_LINE_BYTES.
>> Feel free to add the patch below and:
>>
>> Acked-by: David S. Miller <davem@davemloft.net>
>>
>> Although I think it's better to declare pci_dfl_cache_line_size in
>> linux/pci.h instead of making every arch do the extern decl.
>
> I agree, that would make more sense.
>
> Otherwise it looks good to me:
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Great, I'll incorporate both comments and repost the patchset after
Benjamin's testing or before the end of this week.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-06-30 3:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 7:12 [RFC PATCH 1/2] pci: determine CLS more intelligently Tejun Heo
2009-06-25 7:12 ` [RFC PATCH 2/2] pccard: configure CLS on attach Tejun Heo
2009-06-25 9:05 ` [RFC PATCH 1/2] pci: determine CLS more intelligently David Miller
2009-06-25 17:33 ` Greg KH
2009-06-30 3:07 ` Tejun Heo [this message]
2009-06-30 10:22 ` Benjamin Herrenschmidt
2009-06-25 10:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A49815C.1080603@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=daniel.ritz@gmx.ch \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=hancockr@shaw.ca \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=towerlexa@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox