Re: [PATCH -tip 3/3] kprobes: cleanup: use list instead of hlist for insn_pages

Ingo Molnar
2009-06-30T21:25:52Z

* Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Use struct list instead of struct hlist for managing insn_pages,
> because insn_pages doesn't use hash table.

> struct kprobe_insn_page {
> - struct hlist_node hlist;
> + struct list_head list;

Hm, you know that this increases the size of kprobe_insn_page by 4/8
bytes, right?

hlists are not just used for hashes - but also when we want a more
compact / smaller list head.

How many kprobe_insn_page's can be allocated in the system,
maximally?

Ingo