* [PATCH] KVM: fix lock imbalance
@ 2009-06-29 16:05 Jiri Slaby
2009-07-01 8:17 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2009-06-29 16:05 UTC (permalink / raw)
To: avi; +Cc: kvm, linux-kernel, Jiri Slaby
There is a missing unlock on one fail path in ioapic_mmio_write,
fix that.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
virt/kvm/ioapic.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index d8b2eca..2b3307b 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -290,7 +290,7 @@ static void ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
data = *(u32 *) val;
else {
printk(KERN_WARNING "ioapic: Unsupported size %d\n", len);
- return;
+ goto unlock;
}
addr &= 0xff;
@@ -311,6 +311,7 @@ static void ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
default:
break;
}
+unlock:
mutex_unlock(&ioapic->kvm->irq_lock);
}
--
1.6.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: fix lock imbalance
2009-06-29 16:05 [PATCH] KVM: fix lock imbalance Jiri Slaby
@ 2009-07-01 8:17 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-07-01 8:17 UTC (permalink / raw)
To: Jiri Slaby; +Cc: kvm, linux-kernel
On 06/29/2009 07:05 PM, Jiri Slaby wrote:
> There is a missing unlock on one fail path in ioapic_mmio_write,
> fix that.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-01 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-29 16:05 [PATCH] KVM: fix lock imbalance Jiri Slaby
2009-07-01 8:17 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox