From: Patrick McHardy <kaber@trash.net>
To: Andreas Jaggi <aj@open.ch>
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru,
davem@davemloft.net, linux-kernel@vger.kernel.org,
shemminger@osdl.org
Subject: Re: [PATCH] gre: copy ToS/DiffServ bits to outer IP header
Date: Wed, 01 Jul 2009 12:28:27 +0200 [thread overview]
Message-ID: <4A4B3A4B.9000502@trash.net> (raw)
In-Reply-To: <4A49D55A.4050600@open.ch>
Andreas Jaggi wrote:
> Now using the rtnl_link interface.
Your patches are seriously whitespace-damaged. Please make sure
to send them properly (test by sending to yourself first).
> diff -urN vanilla-linux-2.6.29.4/include/linux/if_tunnel.h
> dev-gre/include/linux/if_tunnel.h
> --- vanilla-linux-2.6.29.4/include/linux/if_tunnel.h 2009-05-19
> 01:52:34.000000000 +0200
> +++ dev-gre/include/linux/if_tunnel.h 2009-06-30 08:22:52.000000000
> +0200
> @@ -34,6 +34,7 @@
> __be32 i_key;
> __be32 o_key;
> struct iphdr iph;
> + __u8 copy_tos;
You can't change this structure, this will break compatibility.
> };
>
> /* SIT-mode i_flags */
> @@ -63,6 +64,7 @@
> IFLA_GRE_REMOTE,
> IFLA_GRE_TTL,
> IFLA_GRE_TOS,
> + IFLA_GRE_COPY_TOS,
> IFLA_GRE_PMTUDISC,
> __IFLA_GRE_MAX,
You can't add new attributes in the middle, they need to be added at
the end.
next prev parent reply other threads:[~2009-07-01 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 13:07 [PATCH] gre: copy ToS/DiffServ bits to outer IP header Andreas Jaggi
2009-06-29 13:48 ` Patrick McHardy
2009-06-30 9:05 ` Andreas Jaggi
2009-07-01 10:28 ` Patrick McHardy [this message]
2009-06-30 9:06 ` Andreas Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4B3A4B.9000502@trash.net \
--to=kaber@trash.net \
--cc=aj@open.ch \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox