From: Gregory Haskins <ghaskins@novell.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mst@redhat.com, avi@redhat.com,
davidel@xmailserver.org
Subject: Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface
Date: Wed, 01 Jul 2009 16:21:06 -0400 [thread overview]
Message-ID: <4A4BC532.3020503@novell.com> (raw)
In-Reply-To: <20090701160902.3615.39426.stgit@dev.haskins.net>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
Gregory Haskins wrote:
>
> + eventfd = eventfd_ctx_fileget(file);
> + if (IS_ERR(file)) {
> + ret = PTR_ERR(file);
> + goto fail;
> + }
> +
> + irqfd->eventfd = eventfd;
> +
>
<sigh>
Just noticed the typo (return "eventfd" but error-check "file"). Looks
like I will need at least a v9. Is there any other feedback before I
push out the fix for v8?
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]
next prev parent reply other threads:[~2009-07-01 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 16:08 [KVM PATCH v8 0/3] irqfd fixes and enhancements Gregory Haskins
2009-07-01 16:09 ` [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get interface Gregory Haskins
2009-07-01 20:21 ` Gregory Haskins [this message]
2009-07-02 14:16 ` Avi Kivity
2009-07-02 14:27 ` Gregory Haskins
2009-07-02 14:42 ` Avi Kivity
2009-07-01 16:09 ` [KVM PATCH v8 2/3] KVM: add irqfd DEASSIGN feature Gregory Haskins
2009-07-01 16:09 ` [KVM PATCH v8 3/3] KVM: create irqfd-cleanup-wq on demand Gregory Haskins
2009-07-02 14:22 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4BC532.3020503@novell.com \
--to=ghaskins@novell.com \
--cc=avi@redhat.com \
--cc=davidel@xmailserver.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox