Re: [GIT] Networking

Ben Hutchings
2013-05-02T20:18:15Z

On Thu, 2013-05-02 at 14:53 -0400, John Stoffel wrote:
> >>>>> "David" == David Miller <davem@davemloft.net> writes:
>
> David> From: Bjørn Mork <bjorn@mork.no>
> David> Date: Thu, 02 May 2013 11:06:42 +0200
>
> >> From d957cf339bf625869c39d852ac6733ef597ecef9 Mon Sep 17 00:00:00 2001
> >> From: Bjørn Mork <bjorn@mork.no>
> >> Date: Thu, 2 May 2013 10:37:05 +0200
> >> Subject: [PATCH] net: vlan,ethtool: netdev_features_t is more than 32 bit
> >> MIME-Version: 1.0
> >> Content-Type: text/plain; charset=UTF-8
> >> Content-Transfer-Encoding: 8bit
> >>
> >> Signed-off-by: Bjørn Mork <bjorn@mork.no>
>
> David> Also applied and queued up for -stable.
>
> David> These changes show me that this special type isn't providing type
> David> safety in the way that we actually need it.
>
> David> Something like how we do the MM page table types would work better:
>
> David> typedef struct { u64 val; } netdev_features_t;
>
> David> #define __netdev_feature(X) ((netdev_features_t) { X } )
>
> David> and also with the appropriate set of accessors.
>
> David> Then you can't get it wrong without a compile error.
>
> Isn't part of the problem that you're exporting it into /sys in a
> binary format?
[...]

Features are exported through SIOCETHTOOL, not sysfs (though they *used*
to be there).

The 'flags' attribue in sysfs is something different.

Ben.

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.