Re: [GIT] Networking

Linus Torvalds
2011-10-25T12:03:33Z

On Tue, Oct 25, 2011 at 1:56 PM, Greg KH <gregkh@suse.de> wrote:
>
> The "crazy" tool was using 'git am'.  The problem was that I missed the
> fact that the first line of the patch sent to me duplicated the subject
> line.  It's a really common problem when people generate patches and
> send them off by email, I just forgot to edit the patches from Mikulas
> to remove them, my fault, sorry.

Ok, please (a) check these things before applying patches, and (b)
COMPLAIN TO EVERY SOURCE THAT SENDS YOU CRAP.

The push-back so that it doesn't happen again is important.

In other words: Mikulas - whatever tool you're using, stop using it,
or start using it correctly. Duplicating the header line in the body
of the email is crap and wrong. If you want to duplicate it in the
email, add the "Subject:" prefix to it (same goes for "Date:" and
particularly "From:" - those fields are actually destroyed by
forwarding the patches over email - unlike the subject line)

Linus