Re: [GIT]: Networking

Eric Dumazet
2009-12-12T10:49:18Z

Le 12/12/2009 11:10, William Allen Simpson a écrit :
> David Miller wrote:
>> David S. Miller (4):
>> Merge branch 'master' of
>> git://git.kernel.org/.../linville/wireless-next-2.6
>> tcp: Remove runtime check that can never be true.
>
> This is a poor patch that was never sent to the netdev list for review.
> Copies to
> and from user space should always check for buffer overruns. A better
> patch was
> submitted (attached) some time ago.
>
> Miller's patch has 2 flaws:
>
> 1) It accidentally removed a comment line that describes the purpose of
> the
> following memcpy(), paralleling language in the internet-draft.
>
> 2) It fails to test for buffer overruns. The existing code has an
> accurate test,
> that compiles (to no code) correctly with current gcc. But it produces
> a warning
> in some (fairly old) gcc versions.
>
> Instead, the better patch uses the Kernel defined BUILD_BUG_ON(). Please
> substitute the better patch in the main tree.
>
>
>> Merge branch 'master' of
>> git://git.kernel.org/.../linville/wireless-2.6
>> Merge branch 'master' of /home/davem/src/GIT/linux-2.6/
>>

William, as I already said, you wont solve your problem with David
alerting whole earth, Linus, God, whoever, because we dont care,
we have our own problems.

This drama is really ridiculous, could we go forward, correct bugs,
add documentation, and so on ?

If you really want this BUILD_BUG_ON() (because some dev could
introduce a bug changing TCP_COOKIE_PAIR_SIZE or TCP_MSS_DEFAULT (???)
in the future, without David or other network dev noticing this),
please submit a _normal_ patch against net-2.6 and through David Miller,
the official network maintainer, your best friend for network patches.