Re: [GIT] Networking

Dan Williams
2013-05-02T16:32:09Z

On Wed, 2013-05-01 at 18:28 -0700, Linus Torvalds wrote:
> On Wed, May 1, 2013 at 1:47 PM, David Miller <davem@davemloft.net> wrote:
> >
> > Highlights (1721 non-merge commits, this has to be a record of some
> > sort):
>
> Lowlight: it completely breaks my machine with r8169 ethernet. In the
> networkmanager applet, it claims no cable connection, which is a bit
> odd, because (a) it works with an older kernel and (b) the kernel
> messages actually say
>
> r8169 0000:01:00.0 eth0: link up

NM calls ETHTOOL_GLINK and if that returns success, NM expects the
driver to support carrier detection. NM then listens to netlink for
device flags changes, and uses IFF_LOWER_UP to determine carrier on/off
state. NM does not use NETIF_F_VLAN_CHALLENGED or any of the other
ETHTOOL_GFEATURES flags yet, but will in the future.

Is the link status accurately reflected by /sys/class/net/eth0/carrier ?

Dan

> but nothing actually works.
>
> r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> r8169 0000:01:00.0 eth0: RTL8168d/8111d at 0xffffc90010ece000,
> e0:cb:4e:95:1a:d7, XID 083000c0 IRQ 53
> r8169 0000:01:00.0 eth0: jumbo features [frames: 9200 bytes, tx
> checksumming: ko]
>
> Any ideas?
>
> Linus
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html