From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-kernel@vger.kernel.org, chrisv@cyberswitching.com,
daniel@caiaq.de, iws@ovro.caltech.edu, dmitry.torokhov@gmail.com,
hmh@hmh.eng.br, david-b@pacbell.net
Subject: Re: [PATCH] IIO: Add missing I2C dependencies for max1363 and tsl2561
Date: Sat, 04 Jul 2009 12:22:38 +0000 [thread overview]
Message-ID: <4A4F498E.3010109@cam.ac.uk> (raw)
In-Reply-To: <20090703211348.4033c109@hyperion.delvare>
Jean Delvare wrote:
> On Fri, 03 Jul 2009 17:12:13 +0000, Jonathan Cameron wrote:
>> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>>
>> I will roll these into the original patches at some point, but
>> for now they are here.
>>
>> Thanks to David Brownell for spotting this.
>> ---
>> drivers/iio/adc/Kconfig | 2 +-
>> drivers/iio/light/Kconfig | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index cb773d2..ab2066c 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -6,7 +6,7 @@ comment "Analog to digital convertors"
>>
>> config MAX1363
>> tristate "MAXIM max1363 ADC driver"
>> - depends on IIO
>> + depends on IIO && I2C
>> help
>> Say yes here to build support for many MAXIM i2c analog to digital
>> convertors (ADC). (max1361, max1362, max1363, max1364, max1136,
>> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
>> index 620e249..62d502c 100644
>> --- a/drivers/iio/light/Kconfig
>> +++ b/drivers/iio/light/Kconfig
>> @@ -6,7 +6,7 @@ comment "Light sensors"
>>
>> config TSL2561
>> tristate "TAOS TSL2561 light-to-digital convertor"
>> - depends on IIO
>> + depends on IIO && I2C
>> help
>> Say yes bere to build support for the TAOS light to digital
>> convertor. This chip has two light sensors. One is broadband
>
> Unrelated suggestion: you could surround all the driver configuration
> entries with a big
>
> if IIO
>
> (...)
>
> endif # IIO
>
> This would save you the hassle of adding "depends on IIO" to every
> driver. Many subsystems have resorted to this technique by now.
>
Thanks Jean, I hadn't realized you could do that.
Jonathan
prev parent reply other threads:[~2009-07-04 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 13:47 [PATCH 00/14] IIO V4. Industrial I/O Subsystem Jonathan Cameron
2009-07-02 13:47 ` [PATCH 01/14] IIO: core support for device registration and management Jonathan Cameron
2009-07-02 13:47 ` [PATCH 02/14] IIO: max1363 ADC driver Jonathan Cameron
2009-07-02 13:47 ` [PATCH 03/14] IIO: tsl2561 digital light sensor core support Jonathan Cameron
2009-07-02 13:47 ` [PATCH 04/14] IIO: lis3l02dq accelerometer " Jonathan Cameron
2009-07-02 13:47 ` [PATCH 05/14] IIO: kxsd9 accelerometer minimal support Jonathan Cameron
2009-07-02 13:47 ` [PATCH 06/14] IIO: Add generic ring buffer support to the IIO core Jonathan Cameron
2009-07-02 13:47 ` [PATCH 07/14] IIO: VTI sca3000 series accelerometer driver (spi) Jonathan Cameron
2009-07-02 13:47 ` [PATCH 08/14] IIO: Trigger support added to core Jonathan Cameron
2009-07-02 13:47 ` [PATCH 09/14] IIO: Ring buffer: Initial pass at rarely locked ring buffer Jonathan Cameron
2009-07-02 13:47 ` [PATCH 10/14] IIO: lis3l02dq ring buffer and data ready trigger support Jonathan Cameron
2009-07-02 13:47 ` [PATCH 11/14] IIO: max1363 add software ring buffer support using ring_sw Jonathan Cameron
2009-07-02 13:47 ` [PATCH 12/14] IIO: Periodic timer based trigger Jonathan Cameron
2009-07-02 13:47 ` [PATCH 13/14] IIO: Proof of concept gpio trigger Jonathan Cameron
2009-07-02 13:47 ` [PATCH 14/14] IIO: Initial documentation Jonathan Cameron
2009-07-03 17:12 ` [PATCH] IIO: Add missing I2C dependencies for max1363 and tsl2561 Jonathan Cameron
2009-07-03 19:13 ` Jean Delvare
2009-07-04 12:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4F498E.3010109@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=chrisv@cyberswitching.com \
--cc=daniel@caiaq.de \
--cc=david-b@pacbell.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=iws@ovro.caltech.edu \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox