From: Robert Hancock <hancockrwd@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: value of returning positive error code from module_init()?
Date: Sat, 04 Jul 2009 12:01:34 -0600 [thread overview]
Message-ID: <4A4F98FE.4080903@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0907041236440.3907@localhost>
On 07/04/2009 10:38 AM, Robert P. J. Day wrote:
> whoops, i forgot to ask this as well. accidentally, i returned a
> positive value from a module_init() routine, which loaded the module
> and generated in /var/log/messages:
>
> ...
> Jul 4 12:34:43 localhost kernel: hi module being loaded.
> Jul 4 12:34:43 localhost kernel: sys_init_module: 'hi'->init
> suspiciously returned 42, it should follow 0/-E convention
> Jul 4 12:34:43 localhost kernel: sys_init_module: loading module
> anyway...
> Jul 4 12:34:43 localhost kernel: Pid: 3881, comm: insmod Tainted: G
> M 2.6.29.5-191.fc11.x86_64 #1
> Jul 4 12:34:43 localhost kernel: Call Trace:
> Jul 4 12:34:43 localhost kernel: [<ffffffff8106f33b>]
> sys_init_module+0x13e/0x1cd
> Jul 4 12:34:43 localhost kernel: [<ffffffff8101133a>]
> system_call_fastpath+0x16
> ...
>
> i'd never seen that before, i guess because i never returned a
> positive error code. is there a tradition for returning positive
> values? for what purpose? thanks.
My guess would be no, hence the warning you're not supposed to do it..
prev parent reply other threads:[~2009-07-04 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-04 16:38 value of returning positive error code from module_init()? Robert P. J. Day
2009-07-04 18:01 ` Robert Hancock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4F98FE.4080903@gmail.com \
--to=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox