Re: [PATCH 1/8] ksym_tracer: Extract trace entry from struct trace_ksym

Li Zefan
2009-07-08T00:55:49Z

>> - entry = ring_buffer_event_data(event);
>> + entry = ring_buffer_event_data(event);
>> + entry->ip = instruction_pointer(regs);
>> + entry->type = hbp->info.type;
>> strlcpy(entry->ksym_name, hbp->info.name, KSYM_SYMBOL_LEN);
>> - entry->ksym_hbp = hbp;
>> - entry->ip = instruction_pointer(regs);
>> - strlcpy(entry->p_name, current->comm, TASK_COMM_LEN);
>> + strlcpy(entry->cmd, current->comm, TASK_COMM_LEN);
>
>
> Ah, I did not realized that the cmdline was that roughly saved.
> It would be more ring-buffer-friendly to use tracing_record_cmdline.
>

Yeah, I'll send an incremental patch later.

>