Re: [PATCH v2 3/3] ftrace: add tracepoint for itimer

Xiao Guangrong
2009-07-07T09:30:16Z

Hi Thomas,

Thanks for your review.

Thomas Gleixner wrote:
> On Mon, 6 Jul 2009, Xiao Guangrong wrote:
>> +TRACE_EVENT(itimer_state,
>> +
>> + TP_PROTO(int which, struct itimerval *value, cputime_t expires),
>> +
>> + TP_ARGS(which, value, expires),
>> +
>> + TP_STRUCT__entry(
>> + __field( int, which )
>> + __field( void *, timer )
>> + __field( int, state )
>> + __field( cputime_t, expires )
>> + __field( long, value_sec )
>> + __field( long, value_usec )
>> + __field( long, interval_sec )
>> + __field( long, interval_usec )
>> + __string( comm, current->comm )
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->which = which;
>> + __entry->timer = which == ITIMER_REAL ?
>> + &current->signal->real_timer : NULL;
>
> Why do we need this information at all ? There is no value in the
> address of real_timer AFAICT.
>

Thanks for your review. I'll send a new patch with your comments addressed.