Re: [PATCH v2 3/3] ftrace: add tracepoint for itimer

Thomas Gleixner
2009-07-06T19:37:52Z

On Mon, 6 Jul 2009, Mathieu Desnoyers wrote:
> * Xiao Guangrong (xiaoguangrong@cn.fujitsu.com) wrote:
> > +
> > +TRACE_EVENT(itimer_state,
> > +
>
> Hrm, I'd reserve the use of the *_state namespace for something
> different if possible.

See below.

> In LTTng, we have the ability to list a set of data structures at trace
> start (we call this state dump). In this case, we could add a list of
> all active timers at trace start. This is useful if the trace started
> after timer inits.

Can you please spare us the gory details of LTTng. We already know
that it can do everything plus brewing coffee, so no need to advertise
it in every tracing related mail.

> So having "_state" without much meaning here might eventually be
> confusing.
>
> "_action" or "_call" (like IPCs) might be more appropriate ?

Err, where is this an action or a call ? Care to look at the call site
of this tracepoint. It's at the end of do_setitimer() and records the
_state_ of the itimer _after_ the syscall was handled.

> Mathieu

Can you please remove the hundred lines you are not commenting on next
time ?

> > + TP_PROTO(int which, struct itimerval *value, cputime_t expires),

Thanks,

tglx