Re: [PATCH v2 3/3] ftrace: add tracepoint for itimer

Thomas Gleixner
2009-07-07T16:03:48Z

Mathieu,

On Tue, 7 Jul 2009, Mathieu Desnoyers wrote:
> > Err, where is this an action or a call ? Care to look at the call site
> > of this tracepoint. It's at the end of do_setitimer() and records the
> > _state_ of the itimer _after_ the syscall was handled.
> >
>
> Hrm, right. The patch context misled me. I thought it was at the end of
> it_real_fn(), but it's actually in do_setitimer().
>
> OK, looking at it from it's actual context, it makes perfect sense to
> name it that way.
>
> And it could even be used as-is to iterate on all timers at trace start
> as we do in this tracer I won't name. ;-)

:)

> BTW, I was merely pointing out the risk of a name clash here. And I
> had to refer to the tree where this piece of code exists to support the
> point. My intent was not to advertise anything.

While I really do not care much about potential name clashes with out
of tree code, looking at your wrong analysis of the patch and your
mentioning of that unnamed tracer triggered my rant button :)

tglx