From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"K.Prasad" <prasad@linux.vnet.ibm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] ksym_tracer: Extract trace entry from struct trace_ksym
Date: Wed, 08 Jul 2009 08:55:36 +0800 [thread overview]
Message-ID: <4A53EE88.1080003@cn.fujitsu.com> (raw)
In-Reply-To: <20090707212520.GA7412@nowhere>
>> - entry = ring_buffer_event_data(event);
>> + entry = ring_buffer_event_data(event);
>> + entry->ip = instruction_pointer(regs);
>> + entry->type = hbp->info.type;
>> strlcpy(entry->ksym_name, hbp->info.name, KSYM_SYMBOL_LEN);
>> - entry->ksym_hbp = hbp;
>> - entry->ip = instruction_pointer(regs);
>> - strlcpy(entry->p_name, current->comm, TASK_COMM_LEN);
>> + strlcpy(entry->cmd, current->comm, TASK_COMM_LEN);
>
>
> Ah, I did not realized that the cmdline was that roughly saved.
> It would be more ring-buffer-friendly to use tracing_record_cmdline.
>
Yeah, I'll send an incremental patch later.
>
next prev parent reply other threads:[~2009-07-08 0:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 5:52 [PATCH 0/8] ksym_tracer: various fixes Li Zefan
2009-07-07 5:52 ` [PATCH 1/8] ksym_tracer: Extract trace entry from struct trace_ksym Li Zefan
2009-07-07 21:25 ` Frederic Weisbecker
2009-07-08 0:55 ` Li Zefan [this message]
2009-11-21 13:33 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:52 ` [PATCH 2/8] ksym_tracer: Rewrite ksym_trace_filter_read() Li Zefan
2009-07-07 21:29 ` Frederic Weisbecker
2009-07-11 5:54 ` K.Prasad
2009-11-21 13:34 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:53 ` [PATCH 3/8] ksym_tracer: Fix validation of access type Li Zefan
2009-11-21 13:34 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:53 ` [PATCH 4/8] ksym_tracer: Fix validation of length " Li Zefan
2009-11-21 13:34 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:54 ` [PATCH 5/8] ksym_tracer: NIL-terminate user input filter Li Zefan
2009-11-21 13:34 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:54 ` [PATCH 6/8] ksym_tracer: Report error when failed to re-register hbp Li Zefan
2009-11-21 13:34 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:54 ` [PATCH 7/8] ksym_tracer: Fix memory leak Li Zefan
2009-11-21 13:35 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 5:55 ` [PATCH 8/8] ksym_tracer: Fix the output of stat tracing Li Zefan
2009-11-21 13:35 ` [tip:perf/core] " tip-bot for Li Zefan
2009-07-07 23:18 ` [PATCH 0/8] ksym_tracer: various fixes Frederic Weisbecker
2009-07-10 10:01 ` Ingo Molnar
2009-07-11 5:54 ` K.Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A53EE88.1080003@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox