From: "H. Peter Anvin" <hpa@zytor.com>
To: Len Brown <lenb@kernel.org>
Cc: x86@kernel.org, sfi-devel@simplefirmware.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Feng Tang <feng.tang@intel.com>, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 08/12] SFI, x86: hook e820() for memory map initialization
Date: Wed, 08 Jul 2009 14:37:08 -0700 [thread overview]
Message-ID: <4A551184.1020707@zytor.com> (raw)
In-Reply-To: <5bf6b3c7c08a76ea8dc52e9e07728c2958938952.1247025117.git.len.brown@intel.com>
This bothers me... we keep saying that memory map initialization belongs
to the boot loader, and yet we keep doing the opposite. This isn't just
an arbitrary difference, either: it is pretty essential to being able to
use the early range allocator safely.
-hpa
Len Brown wrote:
> From: Feng Tang <feng.tang@intel.com>
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> arch/x86/kernel/e820.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> index c4ca89d..e399d0e 100644
> --- a/arch/x86/kernel/e820.c
> +++ b/arch/x86/kernel/e820.c
> @@ -20,6 +20,7 @@
> #include <linux/pfn.h>
> #include <linux/suspend.h>
> #include <linux/firmware-map.h>
> +#include <linux/sfi.h>
>
> #include <asm/pgtable.h>
> #include <asm/page.h>
> @@ -1437,6 +1438,10 @@ char *__init default_machine_specific_memory_setup(void)
> < 0) {
> u64 mem_size;
>
> + /* if SFI mmap table exists, use SFI to setup e820 mmap */
> + if (!sfi_init_memory_map())
> + return "SFI";
> +
> /* compare results from other methods and take the greater */
> if (boot_params.alt_mem_k
> < boot_params.screen_info.ext_mem_k) {
next prev parent reply other threads:[~2009-07-08 21:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 4:13 [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support Len Brown
2009-07-08 4:13 ` [PATCH 01/12] SFI: Simple Firmware Interface - new MAINTAINERS entry Len Brown
2009-07-08 4:13 ` [PATCH 02/12] SFI, x86: add CONFIG_SFI Len Brown
2009-07-10 5:23 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 03/12] SFI: document boot param "sfi=off" Len Brown
2009-07-28 19:24 ` Bjorn Helgaas
2009-07-28 19:52 ` Len Brown
2009-07-08 4:13 ` [PATCH 04/12] SFI: create include/linux/sfi.h Len Brown
2009-07-10 6:48 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 05/12] SFI: add core support Len Brown
2009-07-10 7:40 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 06/12] ACPI, x86: remove ACPI dependency on some IO-APIC routines Len Brown
2009-07-10 6:51 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 07/12] SFI: add x86 support Len Brown
2009-07-10 6:37 ` Ingo Molnar
2009-07-10 6:48 ` Feng Tang
2009-07-08 4:13 ` [PATCH 08/12] SFI, x86: hook e820() for memory map initialization Len Brown
2009-07-08 21:37 ` H. Peter Anvin [this message]
2009-07-09 1:11 ` Feng Tang
2009-07-09 3:57 ` H. Peter Anvin
2009-07-08 4:13 ` [PATCH 09/12] SFI: Enable SFI to parse ACPI tables Len Brown
2009-07-10 6:10 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 10/12] ACPI: check acpi_disabled in acpi_table_parse() Len Brown
2009-07-08 4:13 ` [PATCH 11/12] SFI, PCI: Hook MMCONFIG Len Brown
2009-07-10 5:52 ` Ingo Molnar
2009-07-10 7:17 ` Feng Tang
2009-07-10 11:14 ` Ingo Molnar
2009-07-08 4:13 ` [PATCH 12/12] SFI: add boot-time initialization hooks Len Brown
2009-07-10 5:18 ` [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support Ingo Molnar
2009-07-11 1:01 ` Len Brown
2009-07-11 8:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A551184.1020707@zytor.com \
--to=hpa@zytor.com \
--cc=feng.tang@intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfi-devel@simplefirmware.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox