From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbZGJFRu (ORCPT ); Fri, 10 Jul 2009 01:17:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751152AbZGJFRn (ORCPT ); Fri, 10 Jul 2009 01:17:43 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:56308 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750885AbZGJFRm (ORCPT ); Fri, 10 Jul 2009 01:17:42 -0400 Message-ID: <4A56CEF8.8040106@cn.fujitsu.com> Date: Fri, 10 Jul 2009 13:17:44 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Frederic Weisbecker CC: Ingo Molnar , LKML , Steven Rostedt , Lai Jiangshan , Pekka Enberg , Eduard - Gabriel Munteanu Subject: Re: [PATCH 2/2] tracing/kmemtrace: Use the %pf format References: <1247107590-6428-1-git-send-email-fweisbec@gmail.com> <1247107590-6428-3-git-send-email-fweisbec@gmail.com> In-Reply-To: <1247107590-6428-3-git-send-email-fweisbec@gmail.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frederic Weisbecker wrote: > Remove the obsolete seq_print_ip_sym() usage and replace it > by the %pf format in order to print function symbols. > > Signed-off-by: Frederic Weisbecker Reviewed-by: Li Zefan ... > - /* Skip node */ > - ret = trace_seq_printf(s, " "); > + /* Skip node and print call site*/ a nitpick: missing a space before '*/' > + ret = trace_seq_printf(s, " %pf\n", (void *)entry->call_site);