* [PATCH 0/2] tracing: convert some seq_print_ip_sym to %pf
@ 2009-07-09 2:46 Frederic Weisbecker
2009-07-09 2:46 ` [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format Frederic Weisbecker
2009-07-09 2:46 ` [PATCH 2/2] tracing/kmemtrace: " Frederic Weisbecker
0 siblings, 2 replies; 7+ messages in thread
From: Frederic Weisbecker @ 2009-07-09 2:46 UTC (permalink / raw)
To: Ingo Molnar
Cc: LKML, Frederic Weisbecker, Steven Rostedt, Li Zefan,
Lai Jiangshan, Pekka Enberg, Eduard - Gabriel Munteanu
Hi,
I've replaced some seq_print_ip_sym by the %pf format.
I also wanted to convert seq_ip_print_sym() internals too, but
it relies on kprobes checks, so I'm not sure what to do there.
Thanks,
Frederic.
The following changes since commit ddc1637af217dbd8bc51f30e6d24e84476a869a6:
Li Zefan (1):
kmemtrace: Print binary output only if 'bin' option is set
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git ..BRANCH.NOT.VERIFIED..
Frederic Weisbecker (2):
tracing/function-graph-tracer: Use the %pf format
tracing/kmemtrace: Use the %pf format
kernel/trace/kmemtrace.c | 25 +++++--------------------
kernel/trace/trace_functions_graph.c | 12 ++----------
2 files changed, 7 insertions(+), 30 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format 2009-07-09 2:46 [PATCH 0/2] tracing: convert some seq_print_ip_sym to %pf Frederic Weisbecker @ 2009-07-09 2:46 ` Frederic Weisbecker 2009-07-10 5:14 ` Li Zefan 2009-07-10 10:42 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker 2009-07-09 2:46 ` [PATCH 2/2] tracing/kmemtrace: " Frederic Weisbecker 1 sibling, 2 replies; 7+ messages in thread From: Frederic Weisbecker @ 2009-07-09 2:46 UTC (permalink / raw) To: Ingo Molnar Cc: LKML, Frederic Weisbecker, Steven Rostedt, Li Zefan, Lai Jiangshan Remove the obsolete seq_print_ip_sym() usage and replace it by the %pf format in order to print function symbols. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Li Zefan <lizf@cn.fujitsu.com> Cc: Lai Jiangshan <laijs@cn.fujitsu.com> --- kernel/trace/trace_functions_graph.c | 12 ++---------- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index d2249ab..abf7c4a 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -565,11 +565,7 @@ print_graph_entry_leaf(struct trace_iterator *iter, return TRACE_TYPE_PARTIAL_LINE; } - ret = seq_print_ip_sym(s, call->func, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - ret = trace_seq_printf(s, "();\n"); + ret = trace_seq_printf(s, "%pf();\n", (void *)call->func); if (!ret) return TRACE_TYPE_PARTIAL_LINE; @@ -612,11 +608,7 @@ print_graph_entry_nested(struct trace_iterator *iter, return TRACE_TYPE_PARTIAL_LINE; } - ret = seq_print_ip_sym(s, call->func, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - ret = trace_seq_printf(s, "() {\n"); + ret = trace_seq_printf(s, "%pf() {\n", (void *)call->func); if (!ret) return TRACE_TYPE_PARTIAL_LINE; -- 1.6.2.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format 2009-07-09 2:46 ` [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format Frederic Weisbecker @ 2009-07-10 5:14 ` Li Zefan 2009-07-10 10:42 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker 1 sibling, 0 replies; 7+ messages in thread From: Li Zefan @ 2009-07-10 5:14 UTC (permalink / raw) To: Frederic Weisbecker; +Cc: Ingo Molnar, LKML, Steven Rostedt, Lai Jiangshan Frederic Weisbecker wrote: > Remove the obsolete seq_print_ip_sym() usage and replace it > by the %pf format in order to print function symbols. > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Li Zefan <lizf@cn.fujitsu.com> > Cc: Lai Jiangshan <laijs@cn.fujitsu.com> > --- > kernel/trace/trace_functions_graph.c | 12 ++---------- > 1 files changed, 2 insertions(+), 10 deletions(-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:tracing/core] tracing/function-graph-tracer: Use the %pf format 2009-07-09 2:46 ` [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format Frederic Weisbecker 2009-07-10 5:14 ` Li Zefan @ 2009-07-10 10:42 ` tip-bot for Frederic Weisbecker 1 sibling, 0 replies; 7+ messages in thread From: tip-bot for Frederic Weisbecker @ 2009-07-10 10:42 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, lizf, fweisbec, rostedt, tglx, laijs, mingo Commit-ID: 68baafcfc46074c4bb4e4c3115c2c76a8a85f37d Gitweb: http://git.kernel.org/tip/68baafcfc46074c4bb4e4c3115c2c76a8a85f37d Author: Frederic Weisbecker <fweisbec@gmail.com> AuthorDate: Thu, 9 Jul 2009 04:46:29 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Fri, 10 Jul 2009 12:07:19 +0200 tracing/function-graph-tracer: Use the %pf format Remove the obsolete seq_print_ip_sym() usage and replace it by the %pf format in order to print function symbols. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Lai Jiangshan <laijs@cn.fujitsu.com> LKML-Reference: <1247107590-6428-2-git-send-email-fweisbec@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- kernel/trace/trace_functions_graph.c | 12 ++---------- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index d2249ab..abf7c4a 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -565,11 +565,7 @@ print_graph_entry_leaf(struct trace_iterator *iter, return TRACE_TYPE_PARTIAL_LINE; } - ret = seq_print_ip_sym(s, call->func, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - ret = trace_seq_printf(s, "();\n"); + ret = trace_seq_printf(s, "%pf();\n", (void *)call->func); if (!ret) return TRACE_TYPE_PARTIAL_LINE; @@ -612,11 +608,7 @@ print_graph_entry_nested(struct trace_iterator *iter, return TRACE_TYPE_PARTIAL_LINE; } - ret = seq_print_ip_sym(s, call->func, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - ret = trace_seq_printf(s, "() {\n"); + ret = trace_seq_printf(s, "%pf() {\n", (void *)call->func); if (!ret) return TRACE_TYPE_PARTIAL_LINE; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] tracing/kmemtrace: Use the %pf format 2009-07-09 2:46 [PATCH 0/2] tracing: convert some seq_print_ip_sym to %pf Frederic Weisbecker 2009-07-09 2:46 ` [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format Frederic Weisbecker @ 2009-07-09 2:46 ` Frederic Weisbecker 2009-07-10 5:17 ` Li Zefan 2009-07-10 10:42 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker 1 sibling, 2 replies; 7+ messages in thread From: Frederic Weisbecker @ 2009-07-09 2:46 UTC (permalink / raw) To: Ingo Molnar Cc: LKML, Frederic Weisbecker, Steven Rostedt, Li Zefan, Lai Jiangshan, Pekka Enberg, Eduard - Gabriel Munteanu Remove the obsolete seq_print_ip_sym() usage and replace it by the %pf format in order to print function symbols. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Li Zefan <lizf@cn.fujitsu.com> Cc: Lai Jiangshan <laijs@cn.fujitsu.com> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> --- kernel/trace/kmemtrace.c | 25 +++++-------------------- 1 files changed, 5 insertions(+), 20 deletions(-) diff --git a/kernel/trace/kmemtrace.c b/kernel/trace/kmemtrace.c index 74903b6..2f6fa47 100644 --- a/kernel/trace/kmemtrace.c +++ b/kernel/trace/kmemtrace.c @@ -389,19 +389,12 @@ kmemtrace_print_alloc_compress(struct trace_iterator *iter) if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Node */ - ret = trace_seq_printf(s, "%4d ", entry->node); + /* Node and call site*/ + ret = trace_seq_printf(s, "%4d %pf\n", entry->node, + (void *)entry->call_site); if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Call site */ - ret = seq_print_ip_sym(s, entry->call_site, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - if (!trace_seq_printf(s, "\n")) - return TRACE_TYPE_PARTIAL_LINE; - return TRACE_TYPE_HANDLED; } @@ -447,19 +440,11 @@ kmemtrace_print_free_compress(struct trace_iterator *iter) if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Skip node */ - ret = trace_seq_printf(s, " "); + /* Skip node and print call site*/ + ret = trace_seq_printf(s, " %pf\n", (void *)entry->call_site); if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Call site */ - ret = seq_print_ip_sym(s, entry->call_site, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - if (!trace_seq_printf(s, "\n")) - return TRACE_TYPE_PARTIAL_LINE; - return TRACE_TYPE_HANDLED; } -- 1.6.2.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] tracing/kmemtrace: Use the %pf format 2009-07-09 2:46 ` [PATCH 2/2] tracing/kmemtrace: " Frederic Weisbecker @ 2009-07-10 5:17 ` Li Zefan 2009-07-10 10:42 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker 1 sibling, 0 replies; 7+ messages in thread From: Li Zefan @ 2009-07-10 5:17 UTC (permalink / raw) To: Frederic Weisbecker Cc: Ingo Molnar, LKML, Steven Rostedt, Lai Jiangshan, Pekka Enberg, Eduard - Gabriel Munteanu Frederic Weisbecker wrote: > Remove the obsolete seq_print_ip_sym() usage and replace it > by the %pf format in order to print function symbols. > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com> ... > - /* Skip node */ > - ret = trace_seq_printf(s, " "); > + /* Skip node and print call site*/ a nitpick: missing a space before '*/' > + ret = trace_seq_printf(s, " %pf\n", (void *)entry->call_site); ^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:tracing/core] tracing/kmemtrace: Use the %pf format 2009-07-09 2:46 ` [PATCH 2/2] tracing/kmemtrace: " Frederic Weisbecker 2009-07-10 5:17 ` Li Zefan @ 2009-07-10 10:42 ` tip-bot for Frederic Weisbecker 1 sibling, 0 replies; 7+ messages in thread From: tip-bot for Frederic Weisbecker @ 2009-07-10 10:42 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, penberg, lizf, eduard.munteanu, fweisbec, rostedt, tglx, laijs, mingo Commit-ID: 6a167c655858cbec4175532fd00417661c87f149 Gitweb: http://git.kernel.org/tip/6a167c655858cbec4175532fd00417661c87f149 Author: Frederic Weisbecker <fweisbec@gmail.com> AuthorDate: Thu, 9 Jul 2009 04:46:30 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Fri, 10 Jul 2009 12:07:20 +0200 tracing/kmemtrace: Use the %pf format Remove the obsolete seq_print_ip_sym() usage and replace it by the %pf format in order to print function symbols. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Reviewed-by: Li Zefan <lizf@cn.fujitsu.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Lai Jiangshan <laijs@cn.fujitsu.com> Cc: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> LKML-Reference: <1247107590-6428-3-git-send-email-fweisbec@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- kernel/trace/kmemtrace.c | 25 +++++-------------------- 1 files changed, 5 insertions(+), 20 deletions(-) diff --git a/kernel/trace/kmemtrace.c b/kernel/trace/kmemtrace.c index 74903b6..2f6fa47 100644 --- a/kernel/trace/kmemtrace.c +++ b/kernel/trace/kmemtrace.c @@ -389,19 +389,12 @@ kmemtrace_print_alloc_compress(struct trace_iterator *iter) if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Node */ - ret = trace_seq_printf(s, "%4d ", entry->node); + /* Node and call site*/ + ret = trace_seq_printf(s, "%4d %pf\n", entry->node, + (void *)entry->call_site); if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Call site */ - ret = seq_print_ip_sym(s, entry->call_site, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - if (!trace_seq_printf(s, "\n")) - return TRACE_TYPE_PARTIAL_LINE; - return TRACE_TYPE_HANDLED; } @@ -447,19 +440,11 @@ kmemtrace_print_free_compress(struct trace_iterator *iter) if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Skip node */ - ret = trace_seq_printf(s, " "); + /* Skip node and print call site*/ + ret = trace_seq_printf(s, " %pf\n", (void *)entry->call_site); if (!ret) return TRACE_TYPE_PARTIAL_LINE; - /* Call site */ - ret = seq_print_ip_sym(s, entry->call_site, 0); - if (!ret) - return TRACE_TYPE_PARTIAL_LINE; - - if (!trace_seq_printf(s, "\n")) - return TRACE_TYPE_PARTIAL_LINE; - return TRACE_TYPE_HANDLED; } ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-07-10 10:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-07-09 2:46 [PATCH 0/2] tracing: convert some seq_print_ip_sym to %pf Frederic Weisbecker 2009-07-09 2:46 ` [PATCH 1/2] tracing/function-graph-tracer: Use the %pf format Frederic Weisbecker 2009-07-10 5:14 ` Li Zefan 2009-07-10 10:42 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker 2009-07-09 2:46 ` [PATCH 2/2] tracing/kmemtrace: " Frederic Weisbecker 2009-07-10 5:17 ` Li Zefan 2009-07-10 10:42 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox