public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Dave Jones <davej@redhat.com>,
	Marcin Slusarz <marcin.slusarz@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux PM List <linux-pm@lists.linux-foundation.org>,
	cpufreq@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: 2.6.31-rc2+: Interrupts enabled after cpufreq_suspend
Date: Sat, 11 Jul 2009 16:33:13 +0200	[thread overview]
Message-ID: <4A58A2A9.7020707@gmail.com> (raw)
In-Reply-To: <20090710201308.GA11075@redhat.com>

Dave Jones wrote:
> On Fri, Jul 10, 2009 at 03:25:11PM -0400, Dave Jones wrote:
> 
>  >     [PATCH] Add suspend method to cpufreq core
>  >     
>  >     In order to properly fix some issues with cpufreq vs. sleep on
>  >     PowerBooks, I had to add a suspend callback to the pmac_cpufreq driver.
>  >     I must force a switch to full speed before sleep and I switch back to
>  >     previous speed on resume.
>  > 
>  > 
>  > Ben, is there something better we can do here ?
>  > 
>  > I really don't want to add an #ifdef __powerpc__ to core code if we can help it.
>  > I'd rather we didn't call into driver guts at all from the suspend path.
> 
> Marcin,
>  Unless we get a better solution proposed, try running with this, which just
> skips doing all that code entirely.

Now it produces only:
powernow-k8: error - out of sync, fix 0x2 0xc, vid 0x12 0x6
(arch/x86/kernel/cpu/cpufreq/powernow-k8.c: powernowk8_target)
but works fine.

If it's nothing to worry about, you can add:
Tested-by: Marcin Slusarz <marcin.slusarz@gmail.com>

Thanks,
Marcin

  reply	other threads:[~2009-07-11 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 15:44 2.6.31-rc2+: Interrupts enabled after cpufreq_suspend Marcin Slusarz
2009-07-10 19:25 ` Dave Jones
2009-07-10 20:13   ` Dave Jones
2009-07-11 14:33     ` Marcin Slusarz [this message]
2009-07-10 22:23   ` Benjamin Herrenschmidt
2009-07-10 23:46     ` Dave Jones
2009-07-16  3:10       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A58A2A9.7020707@gmail.com \
    --to=marcin.slusarz@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox