From: Avi Kivity <avi@redhat.com>
To: Gregory Haskins <gregory.haskins@gmail.com>
Cc: Gregory Haskins <ghaskins@novell.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com
Subject: Re: [KVM PATCH v10 2/2] KVM: add ioeventfd support
Date: Sun, 12 Jul 2009 11:48:06 +0300 [thread overview]
Message-ID: <4A59A346.5040305@redhat.com> (raw)
In-Reply-To: <4A56060C.4090206@gmail.com>
On 07/09/2009 06:00 PM, Gregory Haskins wrote:
>
>> + bool wildcard = args->flags& KVM_IOEVENTFD_FLAG_DATAMATCH ?
>> + true : false;
>>
>>
> Doh! Inverted logic. "wildcard" should be "false" if DATAMATCH is
> defined in the flags.
>
> Avi, please reverse true/false here before accepting (assuming a v11
> respin isn't needed). Of course, if you would prefer me to just submit
> a new patch, that is fine too.
>
>
I changed it to !(...). I find the predicate ? true : false idiom
confusing.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-07-12 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 21:08 [KVM PATCH v10 0/2] ioeventfd (formerly iosignalfd) Gregory Haskins
2009-07-07 21:08 ` [KVM PATCH v10 1/2] KVM: make io_bus interface more robust Gregory Haskins
2009-07-09 18:22 ` Michael S. Tsirkin
2009-07-07 21:08 ` [KVM PATCH v10 2/2] KVM: add ioeventfd support Gregory Haskins
2009-07-09 15:00 ` Gregory Haskins
2009-07-12 8:48 ` Avi Kivity [this message]
2009-07-09 18:23 ` Michael S. Tsirkin
2009-07-09 14:28 ` [KVM PATCH v10 0/2] ioeventfd (formerly iosignalfd) Michael S. Tsirkin
2009-07-12 8:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A59A346.5040305@redhat.com \
--to=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=gregory.haskins@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox