linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Parag Warudkar <parag.warudkar@gmail.com>
Cc: linux-kernel@vger.kernel.org, thomas@m3y3r.de, sds@tycho.nsa.gov,
	jmorris@namei.org, eparis@parisplace.org
Subject: Re: 2.6.31-rc2: BUG: unable to handle kernel NULL pointer dereference
Date: Sun, 12 Jul 2009 22:26:21 +0200	[thread overview]
Message-ID: <4A5A46ED.7010907@gmail.com> (raw)
In-Reply-To: <loom.20090712T172408-520@post.gmane.org>

On 07/12/2009 07:30 PM, Parag Warudkar wrote:
> static void selinux_write_opts(struct seq_file *m,
> 1012                                struct security_mnt_opts *opts)
> 1013 {
> 1014         int i;
> 1015         char *prefix;
> 1016
> 1017         for (i = 0; i < opts->num_mnt_opts; i++) {
> 1018                 char *has_comma;
> 1019
> 1020                 if (opts->mnt_opts[i])
> 1021                         has_comma = strchr(opts->mnt_opts[i], ',');
>                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
> And that is a NULL pointer dereference - but we just checked for
> opts->mnt_opts[i] for not NULL. 

Note, that there is not a NULL dereference. It dereferences 0x40 which
came in as %rdi. Looks like somebody assigned garbage in there.

Or a single bit mem error. Is memtest OK with this machine?

What warning tainted the kernel before this oops is still interesting...

  reply	other threads:[~2009-07-12 20:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 14:47 2.6.31-rc2: BUG: unable to handle kernel NULL pointer dereference Thomas Meyer
2009-07-12 17:30 ` Parag Warudkar
2009-07-12 20:26   ` Jiri Slaby [this message]
2009-07-12 21:54     ` Parag Warudkar
2009-07-12 21:56     ` Eric Paris
2009-07-13 17:00     ` Thomas Meyer
2009-07-13 17:45       ` Jiri Slaby
2009-07-20 19:23     ` Thomas Meyer
2009-07-22 20:28       ` Rafael J. Wysocki
2009-07-24 11:03         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5A46ED.7010907@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=eparis@parisplace.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parag.warudkar@gmail.com \
    --cc=sds@tycho.nsa.gov \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).