The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] ftrace: Add missing __init in ftrace_profile_debugfs()
Date: Mon, 13 Jul 2009 08:47:44 +0800	[thread overview]
Message-ID: <4A5A8430.7050300@cn.fujitsu.com> (raw)
In-Reply-To: <b9df5fa10907120358t7101511cle30e025c3adcbe54@mail.gmail.com>

Rakib Mullick wrote:
>  Impact: Fix section mismatch.
> 
> The function ftrace_profile_debugfs() references a variable placed in
> .init.data section. Thus causes a section mismatch warning. Since
> ftrace_profile_debugfs() has been called from only
> ftrace_init_debugfs, so we can safely mark ftrace_profile_debugfs as

Thanks. It has been fixed by commit
9d9949ce45b42be7a8157ea00fff2b1005ed844a in tip tree

> init. Also it contains a trivial style fix, __init should be placed
> between function type and function name (ftrace_init_debugfs).
> 

I think both styles are Ok.


  reply	other threads:[~2009-07-13  0:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 10:58 [PATCH] ftrace: Add missing __init in ftrace_profile_debugfs() Rakib Mullick
2009-07-13  0:47 ` Li Zefan [this message]
2009-07-13  3:58   ` Rakib Mullick
2009-07-13  9:01     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5A8430.7050300@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rakib.mullick@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox