From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Alan Stern <stern@rowland.harvard.edu>,
"K.Prasad" <prasad@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hw_breakpoint: remove sample code from hw_breakpoint.h
Date: Mon, 13 Jul 2009 13:28:21 +0800 [thread overview]
Message-ID: <4A5AC5F5.5050206@cn.fujitsu.com> (raw)
In-Reply-To: <20090707210410.GG6184@nowhere>
(sorry for the late reply, I didn't see this mail..)
Frederic Weisbecker wrote:
> On Tue, Jul 07, 2009 at 01:40:11PM +0800, Li Zefan wrote:
>> The sample code is a bit out-dated, and there's already a
>> sample in sample/hw_breakpoint/.
>
>
> IMHO these bits of comments are useful and don't overlap the role
> of the samples in sample/
> They only stand there as a quick summup.
>
> No?
>
The sample here sets a breakpoint on pid_max, which is what the sample
in sample/ does.
And the code here is out-dated (and incomplete). We can fix it, but
whenver someone changes the APIs, he may forget to update the comments.
We know comments never catch up with code.
So I inclined to delete it, and add a link to sample/.
prev parent reply other threads:[~2009-07-13 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 5:40 [PATCH] hw_breakpoint: remove sample code from hw_breakpoint.h Li Zefan
2009-07-07 21:04 ` Frederic Weisbecker
2009-07-13 5:28 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5AC5F5.5050206@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox