From: Frank Rowand <frank.rowand@am.sony.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Joe Perches" <joe@perches.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Brian Swetland" <swetland@google.com>,
"kernel list" <linux-kernel@vger.kernel.org>
Subject: Re: HTC: touchscreen driver
Date: Wed, 15 Jul 2009 12:05:57 -0700 [thread overview]
Message-ID: <4A5E2895.3040907@am.sony.com> (raw)
In-Reply-To: <1247535863.16528.6.camel@Joe-Laptop.home>
Joe Perches wrote:
> On Mon, 2009-07-13 at 18:29 -0700, Arve Hjønnevåg wrote:
>> On Mon, Jul 13, 2009 at 3:07 PM, Pavel Machek<pavel@ucw.cz> wrote:
>>> - printk(KERN_ERR "synaptics_ts_work_func: i2c_transfer failed\n");
>>> + printk(KERN_ERR "ts_work: i2c_transfer failed\n");
>> This will make it harder to read the kernel logs since the driver is
>> no longer specified.
>
> How about converting to:
>
> #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__
> or
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> and pr_<level>()
dev_printk() and the related helpers in include/linux/device.h
might also be useful.
-Frank Rowand
---
Sony Corporation of America
next prev parent reply other threads:[~2009-07-15 19:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090710084323.GA6522@elf.ucw.cz>
[not found] ` <a55d774e0907100155m25366994pe9ec5d0f5f868818@mail.gmail.com>
[not found] ` <20090710103243.GB7789@elf.ucw.cz>
[not found] ` <a55d774e0907100431j3fdc4671i6b185019594367fa@mail.gmail.com>
[not found] ` <20090713202302.GC2569@elf.ucw.cz>
2009-07-13 20:57 ` HTC: touchscreen driver Pavel Machek
2009-07-13 22:07 ` Pavel Machek
2009-07-14 1:29 ` Arve Hjønnevåg
2009-07-14 1:44 ` Joe Perches
2009-07-14 9:46 ` Pavel Machek
2009-07-15 19:05 ` Frank Rowand [this message]
2009-07-14 9:23 ` Pavel Machek
2009-07-14 9:46 ` Pavel Machek
2009-07-14 22:07 ` Arve Hjønnevåg
2009-07-14 22:16 ` Pavel Machek
2009-07-14 22:45 ` Arve Hjønnevåg
2009-07-15 6:21 ` Trilok Soni
2009-07-15 6:48 ` Arve Hjønnevåg
2009-07-19 21:23 ` Pavel Machek
2009-07-20 3:43 ` Arve Hjønnevåg
2009-07-20 10:47 ` Pavel Machek
2009-07-21 10:11 ` Pavel Machek
2009-07-22 1:12 ` Arve Hjønnevåg
2009-07-23 21:25 ` Pavel Machek
2009-07-24 0:11 ` Arve Hjønnevåg
2009-07-27 23:14 ` Pavel Machek
2009-07-27 23:38 ` Arve Hjønnevåg
2009-07-14 10:02 ` Pavel Machek
2009-07-14 1:48 ` Daniel Walker
2009-07-14 6:47 ` Trilok Soni
2009-07-14 0:17 ` Brian Swetland
2009-07-14 9:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5E2895.3040907@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=arve@android.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox