public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jon Smirl <jonsmirl@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Alan Cox <alan@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Why do we probe option roms at 2K boundaries?
Date: Thu, 16 Jul 2009 09:24:12 +0200	[thread overview]
Message-ID: <4A5ED59C.3010805@redhat.com> (raw)
In-Reply-To: <1247702933.4215.4.camel@dwillia2-linux.ch.intel.com>

Hi all,

On 07/16/2009 02:08 AM, Dan Williams wrote:
> On Wed, 2009-07-15 at 16:13 -0700, Jon Smirl wrote:
>> On Wed, Jul 15, 2009 at 7:10 PM, Alan Cox<alan@lxorguk.ukuu.org.uk>  wrote:
>>>> interrogating a data structure stored in option-rom memory.  My initial
>>>> implementation involved blindly scanning from c0000 to f0000 in 512 byte
>>>> increments.  Neil and others pointed out that this may not be a safe
>>> It isn't safe. If you hit certain ISA devices your system will drop dead.
>>> OTOH I doubt anyone has an intel matrix raid controller and a WD80x3 on
>>> the same box ;)
>> Random link from google, slide 21
>> http://download.microsoft.com/download/9/8/f/98f3fe47-dfc3-4e74-92a3-088782200fe7/TWAR05005_WinHEC05.ppt
>>
>> PCI 3.0+ allows 512b alignment, but you must first make sure you are
>> on a PCI 3.0+ system.
>
> Thanks, I believe this may be the missing difference between my test
> system and Hans'.
>

Probably, I'll happily test any patches for this you come up with, note that I'm
leaving for a week of vacation tomorrow, so it might take some time for me to
get back to you.

Regards,

Hans

      reply	other threads:[~2009-07-16  7:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 23:02 Why do we probe option roms at 2K boundaries? Dan Williams
2009-07-15 23:10 ` Alan Cox
2009-07-15 23:13   ` Jon Smirl
2009-07-16  0:08     ` Dan Williams
2009-07-16  7:24       ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5ED59C.3010805@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alan@linux.intel.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dan.j.williams@intel.com \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox