public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] tracing/function: fix the return value of ftrace_trace_onoff_callback()
Date: Thu, 16 Jul 2009 17:29:27 +0800	[thread overview]
Message-ID: <4A5EF2F7.3090706@cn.fujitsu.com> (raw)
In-Reply-To: <20090715142814.GA6184@nowhere>

>> ftrace_trace_onoff_callback() will return error even if we do the
>> right operation, for example:
>>
>> # echo _spin_*:traceon:10 > set_ftrace_filter
>> -bash: echo: write error: Invalid argument
>> # cat set_ftrace_filter
>> #### all functions enabled ####
>> _spin_trylock_bh:traceon:count=10
>> _spin_unlock_irq:traceon:count=10
>> _spin_unlock_bh:traceon:count=10
>> _spin_lock_irq:traceon:count=10
>> _spin_unlock:traceon:count=10
>> _spin_trylock:traceon:count=10
>> _spin_unlock_irqrestore:traceon:count=10
>> _spin_lock_irqsave:traceon:count=10
>> _spin_lock_bh:traceon:count=10
>> _spin_lock:traceon:count=10
>>
>> We want to set _spin_*:traceon:10 to set_ftrace_filter, it complain
>> with "Invalid argument", but the operation is successful.
>> So, this patch fix it.
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> 
> Looks good, thanks.
> 
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> 

Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>


  reply	other threads:[~2009-07-16  9:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15  4:29 [PATCH 1/2] tracing/function: fix the return value of ftrace_trace_onoff_callback() Xiao Guangrong
2009-07-15  4:32 ` [PATCH 2/2] tracing/function: simplify for __ftrace_replace_code() Xiao Guangrong
2009-07-16  9:29   ` Li Zefan
2009-07-17  4:05   ` Frederic Weisbecker
2009-07-17  4:30     ` Li Zefan
2009-07-17  4:39       ` Frederic Weisbecker
2009-07-15 14:28 ` [PATCH 1/2] tracing/function: fix the return value of ftrace_trace_onoff_callback() Frederic Weisbecker
2009-07-16  9:29   ` Li Zefan [this message]
2009-07-17  3:35     ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5EF2F7.3090706@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox