From: Tejun Heo <tj@kernel.org>
To: Danny Feng <dfeng@redhat.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] block: sysfs fix mismatched queue_var_{store,show} in 64bit kernel
Date: Fri, 17 Jul 2009 16:53:21 +0900 [thread overview]
Message-ID: <4A602DF1.4060409@kernel.org> (raw)
In-Reply-To: <4A602AA1.70908@redhat.com>
Hello,
Danny Feng wrote:
> Thank you very much for the review, I've attached v3 patch follow
> your advices, please help me review.
Thanks. I queued the patch on the following temp block tree.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-block-for-linus
> Another thing on block sysfs is that we can echo some invalid value
> (e.g 123abc), should sysfs return -EINVAL for those?
sysfs nodes are only accessible from root and it's customary to not
invest too much into safe guarding the input. So, leaving as it is
should be fine, I think.
--
tejun
prev parent reply other threads:[~2009-07-17 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 11:56 [PATCH] block: sysfs fix mismatched queue_var_{store,show} in 64bit kernel Xiaotian Feng
2009-07-14 13:53 ` Américo Wang
2009-07-14 15:00 ` Danny Feng
2009-07-14 14:10 ` Johannes Weiner
2009-07-14 14:15 ` [PATCH V2] " Xiaotian Feng
2009-07-17 6:48 ` Tejun Heo
2009-07-17 7:39 ` Danny Feng
2009-07-17 7:53 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A602DF1.4060409@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=dfeng@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox