From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/filters: Improve subsystem filter
Date: Mon, 20 Jul 2009 09:31:43 +0800 [thread overview]
Message-ID: <4A63C8FF.4040001@cn.fujitsu.com> (raw)
In-Reply-To: <20090720012430.GA5172@nowhere>
>>> bool dry_run sounds perhaps more intuitive for what is happening there.
>> I guess you "try_run". ;)
>>
>>> Because "apply" is surprising in a "add_thing" function, it's like
>>> a field to confirm that we know what what we are doing :)
>>>
>>> (May be I start to become a PITA with my naming worries, especially
>>> since I'm usually not good at it in my patches :)
>>>
>> I'll take "try_run". Naming is often hard for me.
>
>
> No I really meant "dry run"
> "Try run" is already a function that would implicitly fit into
> every function :)
>
> Ie, dry run means:
>
> "Behave as if you were truly doing it, just to see if it works.
> But don't really do it"
>
Got it. Thanks. :)
prev parent reply other threads:[~2009-07-20 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 9:03 [PATCH] tracing/filters: Improve subsystem filter Li Zefan
2009-07-17 20:34 ` Frederic Weisbecker
2009-07-20 0:59 ` Li Zefan
2009-07-20 1:24 ` Frederic Weisbecker
2009-07-20 1:31 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A63C8FF.4040001@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox