Re: SBC-FITPC2 watchdog driver fix

Wim Van Sebroeck
2009-11-05T11:51:45Z

Hi Denis,

added in linux-2.6-watchdog-next for further testing.
Will sent this to Linus in a couple of days.

Kind regards,
Wim.

> Signed-off-by: Denis Turischev <denis@compulab.co.il>
>
> This patch fixes device registration process.
>
> diff -Nru linux-2.6.32-rc6.orig/drivers/watchdog/sbc_fitpc2_wdt.c
> linux-2.6.32-rc6/drivers/watchdog/sbc_fitpc2_wdt.c
> --- linux-2.6.32-rc6.orig/drivers/watchdog/sbc_fitpc2_wdt.c
> 2009-11-03 21:37:49.000000000 +0200
> +++ linux-2.6.32-rc6/drivers/watchdog/sbc_fitpc2_wdt.c 2009-11-05
> 13:23:11.000000000 +0200
> @@ -227,7 +227,7 @@
> }
>
> err = misc_register(&fitpc2_wdt_miscdev);
> - if (!err) {
> + if (err) {
> pr_err("cannot register miscdev on minor=%d (err=%d)\n",
> WATCHDOG_MINOR,
> err);
> goto err_margin;