From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0B2B1922F5 for ; Thu, 23 Oct 2025 01:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.132.163.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761181652; cv=none; b=ARSDxh/rXcI85afBHH3hZlCLXF/EsuWht5eIZhA0LW8v5vhbpyZ2tRouXv2jHN6ZRtPQw7B4+sn+p0kt4HDZZPRe04OsmWWgtTQT5Iq3OUmNSVVCroTS5bfgiWcOyy373TacbURkCv0HsL0p6fb1tUM+VCTtHN9mecIkH/7jhSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761181652; c=relaxed/simple; bh=uFxGX+eI6uH+Bh3hEnUm8uApgHL2PeR35JjVEXAeMMg=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T+BpAID+zUCDNJYm8EexzOG7EjyZ1hF7gBOWSoTExUS/8JF2Rdo65ho79o8s6hhlPWHHogK9Mv+NnCd7IagoMnU7FqWegprdG3Uol0/5iC7ijbH5TTeB/ZVAnxTZj2r8Vckhjvsv1i6M1mzCeILhnu1F4VGacMmSsENO4z39diI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=KrCle4za; arc=none smtp.client-ip=18.132.163.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="KrCle4za" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1761181563; bh=XsRWgb+mLGrtoREAsHT1s5qba4+X2pYPCy+f+7l7JVg=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=KrCle4za38OHdE0XaUM+0lv+bzM6zFKskgyX/sW8nZ8va+Fz2puY9bFR4qYw/0BzP ec66T0WtfL7zQKN9nOGf/Ow3PvN5evs7VliQGLZpPvy51cPkbKJli1Zx6T9PcK9gxK tVUvFWk8+XhpA/zwWa5cYcOeLvS3wYDxaF+TTQNM= X-QQ-mid: esmtpgz14t1761181560t1645cf02 X-QQ-Originating-IP: gkSINpiiygpxneEIVwBY685Q0g+hGSeOD1Z1ltMwcms= Received: from = ( [61.145.255.150]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 23 Oct 2025 09:05:58 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 5511248865145279605 EX-QQ-RecipientCnt: 12 Date: Thu, 23 Oct 2025 09:05:58 +0800 From: Troy Mitchell To: Troy Mitchell , Yixun Lan , linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:RISC-V ARCHITECTURE:Keyword:riscv" , "open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" Subject: Re: [PATCH v3 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot Message-ID: <4A64F9771A29AB00+aPl_duwqfb45u4NW@kernel.org> References: <20251021201451.1013640-1-aurelien@aurel32.net> <20251021201451.1013640-2-aurelien@aurel32.net> <20251022004830-GYB1522542@gentoo.org> <52468F28CD7B50FD+aPhurJD4HTXqIGDT@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: Ofb4FPpL3MXsJM99P65gXmjLbYsiTCXyawC0aoBwdBlosOQt9w+p6Jgc E0n1sU02RSyVoLZ7DSO3EQOarHIBJ3TWh6F7GWDMRGrYAnkaejCuIe4W7XTQara7ZYAENvw 3XGnHr7ith3ApvPe8wpfvyFiwFYaBGXQQkE1OO3MUbdHzS5oak6c9Y5pBHkRVtWjpGkxelR wQvivGIbuVBS16YNmhSzVyKv3bu54FQ6RuCiZWiewgKIoujbUUXQEfXDL7vq+WLeH5/Mi1z m3VKocjKuX0CeqOcKglSrDFYCdkHTDVLDNQ6aRUXQBjF+4jj/sEo+4ztSVyVSwqzGYWkbLB GXfq9Wip7E6BzBzyLX1cLaJ6jDifG7zxzUzXpCURbVFpKMpY8dUiX8FMKhn+slV9xkXSNQN igPW9wTQGgva7tmYA2GkEZXz9jeVFFILoYkod6epgDbiWFBXbe5mzZqjPkPjc439V4F1Fh0 NIg6zWXbMFZaTyNO1T+fwRHWfoGUUm+E6uiD1NorCULJ2VqHmOs94p1SR1+JZaqFnFNYkUf XrL/6NcW9Wog8I19QTnZhPzJG95oQA2xKTzFFH9wIulFGlqtsDoRA4ul0hcizf/dTxtU7rR hQIp98UTSX3pgHmR7o/wJR593gsy8k/L+yQU+VB6OU4RRMZvop1WaUYO8ibC7J0V/CTmYfP s+A98ZSF5nVtGL83K8g53Aj238BuA0r+XcXlaw9VC2Jj8uya/81PP8SVUVKNIsUTNyHMYd2 lEq+ZHMJ/WqbhPB/u3oSEgIjIl5alBLFJBvN4Yw1QXH3rEF4bqdZoI6m02W2e57OnOXvfQu UTmlh6521tn+8YOee1b3RbM/iGJhIe1r/E1hkD3BE95a7jCBOhbLxm5wjkzbspkaiqZm0Vh 8N0EZYHaFZ1frSORZkW7Q1cKp/G7xVZ1WbOBJcCg/ELWG8Jiujvnjb8VhxUsDY56B4wVeGC Fn82krpkKfaEedjCL000sgo4G4wD6UvdAgW5PhDJy4n+opmKk0kDw/bqsBbpRL3QGdUCBkN p5oD4XAXttbokom0GEsaiyBN0hF3+/Gu50tbnG9QSYlJRU7r+C3FYoImJgWD3q3MY9MGO1l cVZJ+jVvNTc8rRCocUvABA= X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= X-QQ-RECHKSPAM: 0 On Wed, Oct 22, 2025 at 06:48:45PM +0200, Aurelien Jarno wrote: > On 2025-10-22 13:42, Troy Mitchell wrote: > > > > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > > > > > index 8248895ca9038..6577d73edbda4 100644 > > > > > --- a/drivers/power/reset/Kconfig > > > > > +++ b/drivers/power/reset/Kconfig > > > > > @@ -283,6 +283,15 @@ config POWER_RESET_KEYSTONE > > > > > help > > > > > Reboot support for the KEYSTONE SoCs. > > > > > > > > > > +config POWER_RESET_SPACEMIT_P1 > > > > > + tristate "SpacemiT P1 poweroff and reset driver" > > > > > + depends on ARCH_SPACEMIT || COMPILE_TEST > > > > .. > > > > > + select MFD_SPACEMIT_P1 > > > > I'd suggest to use "depends on" instead of "select", the reason is that > > > > using "select" will sometimes ignore the dependency, considering > > > > the reset driver here is tightly coupled with P1, so I think it's > > > > reasonable to switch to use "depends on", also refer below link > > > > > > > > https://lxr.linux.no/#linux+v6.7.1/Documentation/kbuild/kconfig-language.rst#L144 > > > > > > > > select should be used with care. select will force > > > > a symbol to a value without visiting the dependencies. > > > > By abusing select you are able to select a symbol FOO even > > > > if FOO depends on BAR that is not set. > > > > In general use select only for non-visible symbols > > > > (no prompts anywhere) and for symbols with no dependencies. > > > > That will limit the usefulness but on the other hand avoid > > > > the illegal configurations all over. > > > > > > Thanks for the pointer, I'll fix that in the next version. I used > > > REGULATOR_SPACEMIT_P1 and RTC_DRV_SPACEMIT_P1 as examples, they'll also > > > need to be fixed. > > Yes, I have said here[1]. > > Do you want to fix that? If you don't have time, I can do it. > > For the reboot patch series, I'll do that in the v4, makes sense. > but I would > appreciate if you can do it for the PMIC and RTC drivers. I guess it can > be a patch series with the first patch being the one you already posted. Thanks for your suggestion! I will. - Troy > > > > Note also that without the select, a default value has to be added to > > > MFD_SPACEMIT_P1. > > Yes, I will add it in my patch. Thanks. > > Thanks. > > Regards > Aurelien > > -- > Aurelien Jarno GPG: 4096R/1DDD8C9B > aurelien@aurel32.net http://aurel32.net >