From: "H. Peter Anvin" <hpa@kernel.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: [PATCH, x86]: Fix movq immediate operand constraints in uaccess_64.h
Date: Mon, 20 Jul 2009 20:59:53 -0700 [thread overview]
Message-ID: <4A653D39.4030608@kernel.org> (raw)
In-Reply-To: <4A64D06D.3040109@gmail.com>
Uros Bizjak wrote:
> On 07/19/2009 06:06 PM, Uros Bizjak wrote:
>> Hello!
>>
>> arch/x86/include/asm/uaccess_64.h uses wrong asm operand constraint
>> ("ir") for movq insn. Since movq sign-extends its immediate operand,
>> "er" constraint should be used instead.
>>
>> Attached patch changes all uses of __put_user_asm in uaccess_64.h to
>> use "er" when "q" insn suffix is involved.
>>
>> Patch was compile tested on x86_64 with defconfig.
>>
>> Uros.
>
> Uh, missed signed-off line and Cc, so:
>
Good catch. This seems to also apply to the "Zr" constraints in
asm/uaccess.h.
-hpa
prev parent reply other threads:[~2009-07-21 4:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 16:06 [PATCH, x86]: Fix movq immediate operand constraints in uaccess_64.h Uros Bizjak
2009-07-20 20:15 ` Uros Bizjak
2009-07-21 3:59 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A653D39.4030608@kernel.org \
--to=hpa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox