From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <mike@compulab.co.il>,
linux-kernel@vger.kernel.org, denis@compulab.co.il
Subject: Re: [PATCH] Add reboot fixup for SBC-fitPC2
Date: Wed, 22 Jul 2009 18:24:44 -0700 [thread overview]
Message-ID: <4A67BBDC.7040207@zytor.com> (raw)
In-Reply-To: <20090722173854.fdbcee7f.akpm@linux-foundation.org>
On 07/22/2009 05:38 PM, Andrew Morton wrote:
>
> Neither this patch nor Denis's earlier version contained an adequate
> decription. We aren't told what these "problems" are, so we're unable
> to judge the appropriateness of patch.
>
> Both patches were wordwrapped.
>
> Both patches use an atypical layout style for the comments.
>
> I fixed up some of these things and merged the patch into my tree, for
> sending to Ingo for 2.6.32.
>
> Please send a description of the problem which the patch fixes and I
> shall add that to my copy of the changelog.
>
I queued up an equivalent cleaned up version for tip:x86/urgent that I
was planning to push to Linus. However, as you quite correctly point
out the comments in this file are pretty darn pointless; they add
absolutely no information over what is already in the data structure.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-07-23 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 15:48 [PATCH] Add reboot fixup for SBC-fitPC2 Mike Rapoport
2009-07-23 0:38 ` Andrew Morton
2009-07-23 1:24 ` H. Peter Anvin [this message]
2009-07-30 13:14 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A67BBDC.7040207@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=denis@compulab.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox