[PATCH] Add reboot fixup for SBC-fitPC2

[PATCH] Add reboot fixup for SBC-fitPC2

[Mike Rapoport]

> From: Denis Turischev <denis@compulab.co.il>

This patch adds reboot fixup for CompuLab SBC-fitPC2 board.

Singned-off-by: Denis Turischev <denis@compulab.co.il>
Signedd-off-by: Mike Rapoport <mike@compulab.co.il

diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c
linux-2.6.31-rc3/arch/x86/kernel/reboot.c
--- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c	2009-07-14 04:18:52.000000000
+0300
+++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c	2009-07-16 14:39:48.000000000 +0300
@@ -249,6 +249,15 @@
 			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
 		},
 	},
+	{	/* Handle problems with rebooting on
+				CompuLab SBC-FITPC2 board */
+		.callback = set_bios_reboot,
+		.ident = "CompuLab SBC-FITPC2",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
+		},
+	},
 	{ }
 };


-- 
Sincerely yours,
Mike.

Re: [PATCH] Add reboot fixup for SBC-fitPC2

[Andrew Morton]

On Mon, 20 Jul 2009 18:48:17 +0300
Mike Rapoport <mike@compulab.co.il> wrote:

> > From: Denis Turischev <denis@compulab.co.il>
> 
> This patch adds reboot fixup for CompuLab SBC-fitPC2 board.
> 
> Singned-off-by: Denis Turischev <denis@compulab.co.il>
> Signedd-off-by: Mike Rapoport <mike@compulab.co.il
> 
> diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c
> linux-2.6.31-rc3/arch/x86/kernel/reboot.c
> --- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c	2009-07-14 04:18:52.000000000
> +0300
> +++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c	2009-07-16 14:39:48.000000000 +0300
> @@ -249,6 +249,15 @@
>  			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
>  		},
>  	},
> +	{	/* Handle problems with rebooting on
> +				CompuLab SBC-FITPC2 board */
> +		.callback = set_bios_reboot,
> +		.ident = "CompuLab SBC-FITPC2",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
> +		},
> +	},
>  	{ }
>  };
> 

Neither this patch nor Denis's earlier version contained an adequate
decription.  We aren't told what these "problems" are, so we're unable
to judge the appropriateness of patch.

Both patches were wordwrapped.

Both patches use an atypical layout style for the comments.

I fixed up some of these things and merged the patch into my tree, for
sending to Ingo for 2.6.32.

Please send a description of the problem which the patch fixes and I
shall add that to my copy of the changelog.

Thanks.

Re: [PATCH] Add reboot fixup for SBC-fitPC2

[H. Peter Anvin]

On 07/22/2009 05:38 PM, Andrew Morton wrote:
> 
> Neither this patch nor Denis's earlier version contained an adequate
> decription.  We aren't told what these "problems" are, so we're unable
> to judge the appropriateness of patch.
> 
> Both patches were wordwrapped.
> 
> Both patches use an atypical layout style for the comments.
> 
> I fixed up some of these things and merged the patch into my tree, for
> sending to Ingo for 2.6.32.
> 
> Please send a description of the problem which the patch fixes and I
> shall add that to my copy of the changelog.
> 

I queued up an equivalent cleaned up version for tip:x86/urgent that I
was planning to push to Linus.  However, as you quite correctly point
out the comments in this file are pretty darn pointless; they add
absolutely no information over what is already in the data structure.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: [PATCH] Add reboot fixup for SBC-fitPC2

[Mike Rapoport]

Hi Andrew,

Andrew Morton wrote:
> On Mon, 20 Jul 2009 18:48:17 +0300
> Mike Rapoport <mike@compulab.co.il> wrote:
> 
>>> From: Denis Turischev <denis@compulab.co.il>
>> This patch adds reboot fixup for CompuLab SBC-fitPC2 board.
>>
>> Singned-off-by: Denis Turischev <denis@compulab.co.il>
>> Signedd-off-by: Mike Rapoport <mike@compulab.co.il
>>
>> diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c
>> linux-2.6.31-rc3/arch/x86/kernel/reboot.c
>> --- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c	2009-07-14 04:18:52.000000000
>> +0300
>> +++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c	2009-07-16 14:39:48.000000000 +0300
>> @@ -249,6 +249,15 @@
>>  			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
>>  		},
>>  	},
>> +	{	/* Handle problems with rebooting on
>> +				CompuLab SBC-FITPC2 board */
>> +		.callback = set_bios_reboot,
>> +		.ident = "CompuLab SBC-FITPC2",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
>> +		},
>> +	},
>>  	{ }
>>  };
>>
> 
> Neither this patch nor Denis's earlier version contained an adequate
> decription.  We aren't told what these "problems" are, so we're unable
> to judge the appropriateness of patch.
> 
> Both patches were wordwrapped.

Sorry, my bad. Somehow I though my mail client can send patches without wrapping
them :(

> Both patches use an atypical layout style for the comments.


> I fixed up some of these things and merged the patch into my tree, for
> sending to Ingo for 2.6.32.
> 
> Please send a description of the problem which the patch fixes and I
> shall add that to my copy of the changelog.

sbc-fitpc2 board hangs on reboot without this patch. We saw fixups for Dell and
others that set BIOS reboot and that worked for us as well. So, I'd say that
changelog entry should be

--
x86: DMI match for CompuLab SBC-FITPC2 as it needs BIOS reboot.
-- 

Thanks a lot.

> Thanks.
> 

-- 
Sincerely yours,
Mike.