public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] cpu_hotplug: don't affect current task's affinity
Date: Thu, 23 Jul 2009 10:06:51 +0800	[thread overview]
Message-ID: <4A67C5BB.3070302@cn.fujitsu.com> (raw)
In-Reply-To: <20090722150246.6d28003a.akpm@linux-foundation.org>

Andrew Morton wrote:

> 
> Or are you saying that the mask _should_ have been 0-1,3 but the kernel
> incorrectly set it to "0"?
> 

Yes, the mask should become 0-1,3. when original is 2 after cpu2 is offlined.

When cpu2 is offined

original mask			after cpu2 is offined
1				1
1-2				1
0-3				0-1,3
2				0-1,3
2(the task who do the offline)  0

I think the last line is incorrect. This patch fix it.


> 
> Also, it says "The recovery of the current tasks's cpus_allowed will
> fail under some conditions".  What are those conditions?
> 

A condition is described in changelog(the same as above).

An example of other condition: the CPUSET of the task is changed
when this task do the offline... the last recovery may fails.


      reply	other threads:[~2009-07-23  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14  8:47 [PATCH] cpu_hotplug: don't affect current task's affinity Lai Jiangshan
2009-07-22 22:02 ` Andrew Morton
2009-07-23  2:06   ` Lai Jiangshan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A67C5BB.3070302@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox