public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] task_struct cleanup: make binfmt module get and put per mm_struct
Date: Fri, 24 Jul 2009 13:17:36 +0900	[thread overview]
Message-ID: <4A6935E0.3080002@ct.jp.nec.com> (raw)
In-Reply-To: <4A693569.1090009@ct.jp.nec.com>

From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

The binfmt is a member of mm_struct, so it can be handled per mm_struct
instead of task_struct.

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
 kernel/exit.c |    3 ---
 kernel/fork.c |   11 +++++------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index 07524fa..77b01be 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -953,9 +953,6 @@ NORET_TYPE void do_exit(long code)
 	tsk->exit_code = code;
 	taskstats_exit(tsk, group_dead);
 
-	if (tsk->mm && tsk->mm->binfmt)
-		module_put(tsk->mm->binfmt->module);
-
 	exit_mm(tsk);
 
 	if (group_dead)
diff --git a/kernel/fork.c b/kernel/fork.c
index b81223a..3f3de29 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -494,6 +494,8 @@ void mmput(struct mm_struct *mm)
 			spin_unlock(&mmlist_lock);
 		}
 		put_swap_token(mm);
+		if (mm->binfmt)
+			module_put(mm->binfmt->module);
 		mmdrop(mm);
 	}
 }
@@ -619,6 +621,9 @@ struct mm_struct *dup_mm(struct task_struct *tsk)
 	mm->hiwater_rss = get_mm_rss(mm);
 	mm->hiwater_vm = mm->total_vm;
 
+	if (mm->binfmt && !try_module_get(mm->binfmt->module))
+		goto free_pt;
+
 	return mm;
 
 free_pt:
@@ -1008,9 +1013,6 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 	if (!try_module_get(task_thread_info(p)->exec_domain->module))
 		goto bad_fork_cleanup_count;
 
-	if (p->mm && p->mm->binfmt && !try_module_get(p->mm->binfmt->module))
-		goto bad_fork_cleanup_put_domain;
-
 	p->did_exec = 0;
 	delayacct_tsk_init(p);	/* Must remain after dup_task_struct() */
 	copy_flags(clone_flags, p);
@@ -1295,9 +1297,6 @@ bad_fork_cleanup_cgroup:
 #endif
 	cgroup_exit(p, cgroup_callbacks_done);
 	delayacct_tsk_free(p);
-	if (p->mm && p->mm->binfmt)
-		module_put(p->mm->binfmt->module);
-bad_fork_cleanup_put_domain:
 	module_put(task_thread_info(p)->exec_domain->module);
 bad_fork_cleanup_count:
 	atomic_dec(&p->cred->user->processes);
-- 
1.6.3.3


  reply	other threads:[~2009-07-24  4:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10  8:42 [RFC 1/2] move binfmt filed to signal_struct Hiroshi Shimamoto
2009-07-10  8:43 ` [RFC 2/2] make binfmt module get and put per signal_struct Hiroshi Shimamoto
2009-07-22 20:23 ` [RFC 1/2] move binfmt filed to signal_struct Andrew Morton
2009-07-22 22:03   ` Roland McGrath
2009-07-23 16:18     ` Oleg Nesterov
2009-07-24  0:15       ` Hiroshi Shimamoto
2009-07-24  4:15         ` [PATCH 1/2] task_struct cleanup: move binfmt field to mm_struct Hiroshi Shimamoto
2009-07-24  4:17           ` Hiroshi Shimamoto [this message]
2009-07-24 16:14           ` Oleg Nesterov
2009-07-27  0:27             ` Hiroshi Shimamoto
2009-07-27 16:59               ` Oleg Nesterov
2009-07-28  6:21                 ` Hiroshi Shimamoto
2009-07-28 14:37                   ` Oleg Nesterov
2009-07-30  0:42                     ` [PATCH 0/1] " Hiroshi Shimamoto
2009-07-30  0:43                       ` [PATCH 1/1] " Hiroshi Shimamoto
2009-07-30 17:55                         ` Oleg Nesterov
2009-07-30 19:27                           ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6935E0.3080002@ct.jp.nec.com \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox