From: "Moussa A. Ba" <moussa.a.ba@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Amerigo Wang <xiyou.wangcong@gmail.com>,
akpm@linux-foundation.org, adobriyan@gmail.com, mpm@selenic.com,
mel@csn.ul.ie, yinghan@google.com, npiggin@suse.de,
jaredeh@gmail.com
Subject: [PATCH 1/1] pagemap clear_refs: modify to specify anon or mapped vma clearing
Date: Mon, 27 Jul 2009 13:19:34 -0700 [thread overview]
Message-ID: <4A6E0BD6.50102@gmail.com> (raw)
In-Reply-To: <20090724083926.GA6372@cr0.nay.redhat.com>
This patch makes the clear_refs proc interface a bit more versatile.
It adds support for clearing anonymous pages, file mapped pages or both.
The clear_refs entry is used to reset the Referenced bits on virtual and
physical pages associated with a process.
echo 1 > /proc/PID/clear_refs clears all pages associated with the process
echo 2 > /proc/PID/clear_refs clears anonymous pages only
echo 3 > /proc/PID/clear_refs clears file mapped pages only
Any other value written to the proc entry will clear all pages.
Selective clearing the pages has a measurable impact on performance as it
limits the number of page walks. We have been using this interface and this
adds flexibility to the user user space application implementing the reference
clearing.
Signed-off-by: Jared Hulbert (jaredeh@gmail.com)
Signed-off-by: Moussa A. Ba (moussa.a.ba@gmail.com)
-------
Documentation/filesystems/proc.txt | 7 +++++++
fs/proc/task_mmu.c | 29 +++++++++++++++++++++++++----
2 files changed, 32 insertions(+), 4 deletions(-)
--- a/fs/proc/task_mmu.c 2009-07-21 14:30:01.000000000 -0700
+++ b/fs/proc/task_mmu.c 2009-07-27 11:46:05.000000000 -0700
@@ -462,6 +462,27 @@
return 0;
}
+static void walk_vma_area(struct mm_walk *this_walk,
+ struct vm_area_struct *vma, int type)
+{
+
+ /* Writing 2 to /proc/pid/clear_refs will clear all Anonymous
+ * pages.
+ *
+ * Writing 3 to /proc/pid/clear_refs will clear all file mapped
+ * pages.
+ *
+ * Writing any other value including 1 will clear all pages
+ */
+ if (is_vm_hugetlb_page(vma))
+ return;
+ if (type == 2 && vma->vm_file)
+ return;
+ if (type == 3 && !vma->vm_file)
+ return;
+ walk_page_range(vma->vm_start, vma->vm_end, this_walk);
+}
+
static ssize_t clear_refs_write(struct file *file, const char __user * buf,
size_t count, loff_t * ppos)
{
@@ -469,13 +490,15 @@
char buffer[PROC_NUMBUF], *end;
struct mm_struct *mm;
struct vm_area_struct *vma;
+ int type;
memset(buffer, 0, sizeof(buffer));
if (count > sizeof(buffer) - 1)
count = sizeof(buffer) - 1;
if (copy_from_user(buffer, buf, count))
return -EFAULT;
- if (!simple_strtol(buffer, &end, 0))
+ type = strict_strtol(buffer, &end, 0);
+ if (!type)
return -EINVAL;
if (*end == '\n')
end++;
@@ -491,9 +514,7 @@
down_read(&mm->mmap_sem);
for (vma = mm->mmap; vma; vma = vma->vm_next) {
clear_refs_walk.private = vma;
- if (!is_vm_hugetlb_page(vma))
- walk_page_range(vma->vm_start, vma->vm_end,
- &clear_refs_walk);
+ walk_vma_area(&clear_refs_walk, vma, type);
}
flush_tlb_mm(mm);
up_read(&mm->mmap_sem);
--- a/Documentation/filesystems/proc.txt 2009-07-20 17:29:11.000000000 -0700
+++ b/Documentation/filesystems/proc.txt 2009-07-27 12:08:34.000000000 -0700
@@ -375,6 +375,13 @@
This file is only present if the CONFIG_MMU kernel configuration option is
enabled.
+The clear_refs entry is used to reset the Referenced bits on virtual and physical
+pages associated with a process.
+echo 1 > /proc/PID/clear_refs clears all pages associated with the process
+echo 2 > /proc/PID/clear_refs clears anonymous pages only
+echo 3 > /proc/PID/clear_refs clears file mapped pages only
+Any other value written to the proc entry will clear all pages.
+
1.2 Kernel data
---------------
next prev parent reply other threads:[~2009-07-27 20:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 3:57 [PATCH 1/1] pagemap clear_refs: modify to specify anon or mapped vma clearing Moussa A. Ba
2009-07-24 8:39 ` Amerigo Wang
2009-07-24 18:00 ` Moussa Ba
2009-07-27 20:19 ` Moussa A. Ba [this message]
2009-07-27 20:30 ` Matt Mackall
2009-07-27 20:57 ` David Rientjes
2009-07-27 22:14 ` Moussa Ba
2009-07-27 22:20 ` Matt Mackall
2009-07-27 22:49 ` David Rientjes
2009-07-27 23:38 ` Moussa Ba
2009-07-27 23:42 ` Moussa Ba
2009-07-27 23:58 ` David Rientjes
2009-07-28 3:24 ` Amerigo Wang
2009-07-28 16:44 ` Moussa A. Ba
2009-07-28 21:01 ` David Rientjes
2009-07-28 22:52 ` Moussa A. Ba
2009-07-28 23:52 ` Andrew Morton
2009-07-29 0:00 ` Moussa Ba
2009-07-29 14:58 ` Mel Gorman
2009-07-29 16:41 ` Matt Mackall
2009-07-30 19:21 ` Moussa Ba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6E0BD6.50102@gmail.com \
--to=moussa.a.ba@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jaredeh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mpm@selenic.com \
--cc=npiggin@suse.de \
--cc=xiyou.wangcong@gmail.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox