From: Paulo Marques <pmarques@grupopie.com>
To: Julia Lawall <julia@diku.dk>
Cc: jwoithe@physics.adelaide.edu.au, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 6/12] drivers/platform/x86: Correct redundant test
Date: Tue, 28 Jul 2009 18:52:42 +0100 [thread overview]
Message-ID: <4A6F3AEA.7090102@grupopie.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0907271813490.2682@ask.diku.dk>
Julia Lawall wrote:
> [...]
> ---
> drivers/platform/x86/fujitsu-laptop.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 218b9a1..5306901 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -745,9 +745,6 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)
>
> fujitsu = acpi_driver_data(device);
>
> - if (!device || !acpi_driver_data(device))
> - return -EINVAL;
> -
Shouldn't this still do a:
if (!fujitsu)
return -EINVAL;
to avoid dereferencing a NULL pointer below?
> fujitsu->acpi_handle = NULL;
>
> return 0;
--
Paulo Marques - www.grupopie.com
"All I ask is a chance to prove that money can't make me happy."
next prev parent reply other threads:[~2009-07-28 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 16:14 [PATCH 6/12] drivers/platform/x86: Correct redundant test Julia Lawall
2009-07-28 17:52 ` Paulo Marques [this message]
2009-07-28 20:11 ` Julia Lawall
2009-07-29 0:50 ` Jonathan Woithe
2009-07-29 2:22 ` Julia Lawall
2009-07-29 2:42 ` Jonathan Woithe
2009-07-29 4:58 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6F3AEA.7090102@grupopie.com \
--to=pmarques@grupopie.com \
--cc=julia@diku.dk \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox