public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Stefan Assmann <sassmann@suse.de>
Subject: drivers/pci/quirks.c: irq_reroute_variant is dead code?
Date: Tue, 28 Jul 2009 12:50:08 -0700	[thread overview]
Message-ID: <4A6F5670.4010405@goop.org> (raw)

quirk_reroute_to_boot_interrupts_intel() goes to some effort to scan for
a bunch of Intel devices and set dev->irq_reroute_variant =
INTEL_IRQ_REROUTE_VARIANT.  However, as far as I can see that's the only
reference to dev->irq_reroute_variant and INTEL_IRQ_REROUTE_VARIANT, so
the whole thing appears to have no effect.

Is it all dead code?  Is there something else which should be there missing?

Thanks,
    J

             reply	other threads:[~2009-07-28 19:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28 19:50 Jeremy Fitzhardinge [this message]
2009-08-07 17:33 ` drivers/pci/quirks.c: irq_reroute_variant is dead code? Jesse Barnes
2009-08-08 14:45   ` Ingo Molnar
2009-08-10 16:32     ` Jesse Barnes
2009-08-11  7:47       ` Stefan Assmann
2009-08-11  8:06         ` Ingo Molnar
2009-08-11 12:36           ` Olaf Dabrunz
2009-08-11 13:48             ` Stefan Assmann
2009-09-07 16:09           ` Stefan Assmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A6F5670.4010405@goop.org \
    --to=jeremy@goop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sassmann@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox