RE: [PATCH] pata_rdc: driver for RDC ATA devices

Kevin Huang (黃凱文)
2009-06-25T04:25:58Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="big5", Size: 1649 bytes --]

At first I studied ata_piix driver for our driver, because we need to testing our controller. Then I found it is hard to me.I needed to clearify the unreadable code of hardware setting and configuration.So I just modify and clean up original code. And make it simple for beginner or maintainer. I keep original framework and design for future controllers and updates.
This is my first experience of linux driver . Just for share.

-----Original Message----->> Seems fine and fairly straightforward to me. My lone comment -- go >> through and replace magic numbers with named constants, for e.g. the PCI >> config registers that program timings...
>Its based on your ata_piix driver. Feel free to update that and I'll pull>names and things across to match.---------------------------------------------------------------------------------- [E-mail Confidentiality Notice]The information in this e-mail is confidential and may be legally privileged otherwise protected from disclosure. It is intended solely for the addressee. Access to this e-mail by anyone else is unauthorized .If youare not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and maybe unlawful. Please delete the message and any attachments from your computer system; and destroy all hard copies.
ALL Intellectual Property Rights of RDC Reserved.---------------------------------------------------------------------------------- ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥