Re: [PATCH] pata_rdc: driver for RDC ATA devices

Alan Cox
2009-06-24T16:41:31Z

> Maybe consolidate?
>
> The code seems to have many magic constants that might
> be better #define'd and or'd.

If you've got the spec it doesn't go around trying to award hundreds of
bits obscure names so naming them would be silly. If you've not got the
spec then whether its WOMBAT_DERANDOMISE or 0x04 doesn't really make any
difference to your understanding ;)

(And the spec is public)

It's simply a cut down from ata_piix. If you want to clean up ata_piix a
bit then go for it - send patches to Jeff.