Re: [PATCH] pata_rdc: driver for RDC ATA devices

Jeff Garzik
2009-06-24T19:35:19Z

Alan Cox wrote:
> Try this version instead - forgot to refresh the patch before sending
>
> From: Alan Cox <alan@linux.intel.com>
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/ata/Kconfig | 10 +
> drivers/ata/Makefile | 1
> drivers/ata/pata_rdc.c | 400 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 411 insertions(+), 0 deletions(-)
> create mode 100644 drivers/ata/pata_rdc.c

Requesting that linux-ide be CC'd in the future, for this driver...

Seems fine and fairly straightforward to me. My lone comment -- go
through and replace magic numbers with named constants, for e.g. the PCI
config registers that program timings...

Jeff