Re: [PATCH] pata_rdc: driver for RDC ATA devices

Alan Cox
2009-06-24T22:55:36Z

> Seems fine and fairly straightforward to me. My lone comment -- go
> through and replace magic numbers with named constants, for e.g. the PCI
> config registers that program timings...

Its based on your ata_piix driver. Feel free to update that and I'll pull
names and things across to match.