Re: [PATCH] pata_rdc: driver for RDC ATA devices

Jeff Garzik
2009-06-24T23:38:10Z

Joe Perches wrote:
> On Wed, 2009-06-24 at 23:55 +0100, Alan Cox wrote:
>>> Seems fine and fairly straightforward to me. My lone comment -- go
>>> through and replace magic numbers with named constants, for e.g. the PCI
>>> config registers that program timings...
>> Its based on your ata_piix driver. Feel free to update that and I'll pull
>> names and things across to match.
>
> I sent a few patches to Jeff privately to do just that.
>
> I'm waiting for Jeff to see if he wants me to post
> them publicly or not.

Always post patches publicly... private mail is easily lost, left
undiscussed and unarchived, etc.

> Jeff, your email address in MAINTAINERS is jgarzik@pobox.com.
> Should it be changed to redhat.com or garzik.org or left as is.

MAINTAINERS is accurate :)

Jeff