Re: [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device

[Jason Wessel <jason.wessel@windriver.com>]

Alan Stern wrote:
> What happens across a system suspend?
>
>   

I assume you mean as a test case:

echo -n mem > /sys/power/state

The dbgp device goes away entirely, when used with
earlyprintk=dbgp,keep.  But there is a way to fix it reasonably
easily.  Perhaps you might ack this resume patch, if you agree?

Jason.

---
From: Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH] ehci-dbgp,ehci: Allow dbpg to work with suspend/resume

In order for the dbgp driver to survive suspend/resume, on every ehci
resume operation the debug controller must get re-initialized.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Cc: Greg KH <gregkh@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: dbrownell@users.sourceforge.net
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>

---
 drivers/usb/host/ehci-hub.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -204,6 +204,13 @@ static int ehci_bus_resume (struct usb_h
 		return -ESHUTDOWN;
 	}
 
+	if (unlikely(ehci->debug)) {
+		if (ehci->debug && !dbgp_reset_prep())
+			ehci->debug = NULL;
+		else
+			dbgp_external_startup();
+	}
+
 	/* Ideally and we've got a real resume here, and no port's power
 	 * was lost.  (For PCI, that means Vaux was maintained.)  But we
 	 * could instead be restoring a swsusp snapshot -- so that BIOS was