From: Mark Lord <lkml@rtr.ca>
To: Linux Kernel <linux-kernel@vger.kernel.org>, linux-ext4@vger.kernel.org
Subject: [PATCH] fs/compat_ioctl.c: add missing FS_IOC_FIEMAP support
Date: Sat, 01 Aug 2009 10:59:25 -0400 [thread overview]
Message-ID: <4A74584D.2010300@rtr.ca> (raw)
Add support for the FIEMAP ioctl for 32-bit user on 64-bit kernel.
When using a 32-bit runtime on top of a 64-bit kernel,
programs like "filefrag" and "hdparm --fibmap" do not work correctly.
This is because there's no compat ioctl entry for the FIEMAP call.
FIEMAP returns file extent info, similar to FIBMAP (but better).
Since FIBMAP itself is b0rked on ext4, this leaves no way for a 32-bit
program to reliably get detailed block information for a file
when run on top of a 64-bit kernel. This patch addresses the issue.
Once upstream, this patch could also be a candidate for -stable.
Signed-off-by: Mark Lord <mlord@pobox.com>
--- old/fs/compat_ioctl.c 2009-08-01 10:47:16.601066905 -0400
+++ linux/fs/compat_ioctl.c 2009-08-01 10:49:23.054387926 -0400
@@ -35,6 +35,7 @@
#include <linux/falloc.h>
#include <linux/fs.h>
#include <linux/file.h>
+#include <linux/fiemap.h>
#include <linux/ppp_defs.h>
#include <linux/if_ppp.h>
#include <linux/if_pppox.h>
@@ -1907,6 +1908,7 @@
COMPATIBLE_IOCTL(FIONREAD) /* This is also TIOCINQ */
/* 0x00 */
COMPATIBLE_IOCTL(FIBMAP)
+COMPATIBLE_IOCTL(FS_IOC_FIEMAP)
COMPATIBLE_IOCTL(FIGETBSZ)
/* 'X' - originally XFS but some now in the VFS */
COMPATIBLE_IOCTL(FIFREEZE)
@@ -2805,6 +2807,7 @@
goto out_fput;
#endif
+ case FS_IOC_FIEMAP:
case FIBMAP:
case FIGETBSZ:
case FIONREAD:
next reply other threads:[~2009-08-01 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 14:59 Mark Lord [this message]
2009-08-01 15:17 ` [PATCH] fs/compat_ioctl.c: add missing FS_IOC_FIEMAP support Mark Lord
2009-08-03 17:48 ` Mark Lord
2009-08-03 18:00 ` Arnd Bergmann
2009-08-03 18:00 ` Eric Sandeen
2009-08-03 22:07 ` Mark Lord
2009-08-03 22:21 ` Eric Sandeen
2009-08-03 23:22 ` Andrew Morton
2009-08-04 10:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A74584D.2010300@rtr.ca \
--to=lkml@rtr.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox