Re: [PATCH] kmemcheck: fix sparse warning

[Pekka Enberg <penberg@cs.helsinki.fi>]

Hi,

Johannes Berg wrote:
> On Mon, 2009-07-06 at 11:53 +0200, Johannes Berg wrote:
>> Whether or not the sparse warning
>>
>> warning: do-while statement is not a compound statement
>>
>> is justified or not in this case, it is annoying and
>> trivial to fix.
> 
> Whatever happened to this patch? Did you decide to screw sparse
> warnings?

I thought Vegard applied the patch but I can't see it in kmemcheck.git 
either. Vegard?

			Pekka

>> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>> ---
>>  include/linux/kmemcheck.h |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- wireless-testing.orig/include/linux/kmemcheck.h	2009-07-06 11:41:16.000000000 +0200
>> +++ wireless-testing/include/linux/kmemcheck.h	2009-07-06 11:41:30.000000000 +0200
>> @@ -137,13 +137,13 @@ static inline void kmemcheck_mark_initia
>>  	int name##_end[0];
>>  
>>  #define kmemcheck_annotate_bitfield(ptr, name)				\
>> -	do if (ptr) {							\
>> +	do { if (ptr) {							\
>>  		int _n = (long) &((ptr)->name##_end)			\
>>  			- (long) &((ptr)->name##_begin);		\
>>  		BUILD_BUG_ON(_n < 0);					\
>>  									\
>>  		kmemcheck_mark_initialized(&((ptr)->name##_begin), _n);	\
>> -	} while (0)
>> +	} } while (0)
>>  
>>  #define kmemcheck_annotate_variable(var)				\
>>  	do {								\
>>
>