From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbZHBUg5 (ORCPT ); Sun, 2 Aug 2009 16:36:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753500AbZHBUg5 (ORCPT ); Sun, 2 Aug 2009 16:36:57 -0400 Received: from mail.bluewatersys.com ([202.124.120.130]:40475 "EHLO hayes.bluewaternz.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753391AbZHBUg4 (ORCPT ); Sun, 2 Aug 2009 16:36:56 -0400 Message-ID: <4A75F920.20101@bluewatersys.com> Date: Mon, 03 Aug 2009 08:37:52 +1200 From: Ryan Mallon User-Agent: Thunderbird 2.0.0.22 (X11/20090608) MIME-Version: 1.0 To: Julia Lawall CC: hsweeten@visionengravers.com, linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/15] arch/arm/mach-ep93xx: Use DIV_ROUND_CLOSEST References: In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall wrote: > From: Julia Lawall > > The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d > but is perhaps more readable. > > The semantic patch that makes this change is as follows: > (http://www.emn.fr/x-info/coccinelle/) I had a read through the website, that's a very neat tool. > > // > @haskernel@ > @@ > > #include > > @depends on haskernel@ > expression x,__divisor; > @@ > > - (((x) + ((__divisor) / 2)) / (__divisor)) > + DIV_ROUND_CLOSEST(x,__divisor) > // > > Signed-off-by: Julia Lawall > > --- > arch/arm/mach-ep93xx/core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c > index 4075529..16b92c3 100644 > --- a/arch/arm/mach-ep93xx/core.c > +++ b/arch/arm/mach-ep93xx/core.c > @@ -82,7 +82,7 @@ void __init ep93xx_map_io(void) > */ > static unsigned int last_jiffy_time; > > -#define TIMER4_TICKS_PER_JIFFY ((CLOCK_TICK_RATE + (HZ/2)) / HZ) > +#define TIMER4_TICKS_PER_JIFFY DIV_ROUND_CLOSEST(CLOCK_TICK_RATE, HZ) > > static irqreturn_t ep93xx_timer_interrupt(int irq, void *dev_id) > { Acked-by: Ryan Mallon Can you please apply to the ARM patch system (http://www.arm.linux.org.uk/developer/patches/) unless someone else is picking this up. ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon Unit 5, Amuri Park Phone: +64 3 3779127 404 Barbadoes St Fax: +64 3 3779135 PO Box 13 889 Email: ryan@bluewatersys.com Christchurch, 8013 Web: http://www.bluewatersys.com New Zealand Freecall Australia 1800 148 751 USA 1800 261 2934