Re: [RFC][PATCH 5/5] tracing/filters: Provide support for char * pointers

Li Zefan
2009-08-06T03:51:39Z

>> How about add __field_type()? So we can define:
>>
>> __field_type(char *, str, FILTER_PTR_STR)
>>
>> the advantage is he who wrote the code really knows this field is safe
>> to be used in filtering as a string.
>>
>> I had some patches that does similar job. I can rewrite and post them.
>
> Ah good idea. That may even be useful for further typedef'ed types which
> filter process match existing supported types.
>

That's why I wrote those patches, to allow:

# dev is type dev_t
echo "dev == 8:0" > filter

# callsite is void *
echo "callsite == kfree_skb" > filter

> Just one neat however: __field_type looks too much ambiguous. __field() is
> already here to define a typed field. This seems confusing.
>
> Why not __field_ext() for "extended"? We may probably add more flags
> than FILTER_PTR_STR in the future to define options for filtering or even
> for larger scope.
>

Sure. You know I'm not good at naming. ;)

> I then wait for your patches to be posted and I'll integrate them in the
> current queue.
>

Will soon be ready.