Re: [RFC][PATCH 4/5] tracing/filters: Provide basic regex support

Li Zefan
2009-08-03T05:41:41Z

Frederic Weisbecker wrote:
> This patch provides basic support for regular expressions in filters.
> The common filter file doesn't support any regex but a new
> filter_regex file is created for each subsystem/event.
>
> It supports the following types of regexp:
>
> - *match_beginning
> - *match_middle*
> - match_end*
> - !don't match
>

I don't see why adding "filter_regex" is necessary, why not just make
"filter" support regex?

> Every string is now handled as a regexp in the filter framework, which
> helps to factorize the code for handling both simple strings and
> regexp comparisons.
>
> (The regexp code has been savagely cherry picked from ftrace.c
> writtent by Steve. If this patch makes its way, I'll be happy
> to change ftrace to use the new filter helpers)