Re: [RFC][PATCH 3/5] tracing/filters: Cleanup useless headers

Frederic Weisbecker
2009-08-05T22:31:03Z

On Mon, Aug 03, 2009 at 01:19:21PM +0800, Li Zefan wrote:
> 15:23, Frederic Weisbecker wrote:
> > Cleanup remaining headers inclusion that were only useful when
> > the filter framework and its tracing related filesystem user interface
> > weren't yet separated.
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Tom Zanussi <tzanussi@gmail.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > ---
> > kernel/trace/trace_events_filter.c | 3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> > index b9aae72..a2f8bef 100644
> > --- a/kernel/trace/trace_events_filter.c
> > +++ b/kernel/trace/trace_events_filter.c
> > @@ -18,9 +18,6 @@
> > * Copyright (C) 2009 Tom Zanussi <tzanussi@gmail.com>
> > */
> >
> > -#include <linux/debugfs.h>
> > -#include <linux/uaccess.h>
> > -#include <linux/module.h>
>
> But module.h is needed for the use of EXPORT_SYMBOL_GPL().

Oh, indeed, I'll fix that in the v2.

Thanks.

>
> > #include <linux/ctype.h>
> > #include <linux/mutex.h>
> >