Re: [tip:x86/urgent] x86: Add quirk to make Apple MacBook5,2 use reboot=pci

Ozan Çağlayan
2009-08-03T17:40:23Z

tip-bot for Paul Mackerras wrote:
> Commit-ID: 1961b971360c685e15dff59929c39ced6c46e171
> Gitweb: http://git.kernel.org/tip/1961b971360c685e15dff59929c39ced6c46e171
> Author: Paul Mackerras <paulus@samba.org>
> AuthorDate: Mon, 3 Aug 2009 22:47:32 +1000
> Committer: H. Peter Anvin <hpa@zytor.com>
> CommitDate: Mon, 3 Aug 2009 08:07:18 -0700
>
> x86: Add quirk to make Apple MacBook5,2 use reboot=pci
>
> The latest Apple MacBook (MacBook5,2) doesn't reboot successfully
> under Linux; neither the EFI reboot method nor the default method
> using the keyboard controller works (the system just hangs and doesn't
> reset). However, the method using the "PCI reset register" at 0xcf9
> does work.
>
> This adds a quirk to detect this machine via DMI and force the
> reboot_type to BOOT_CF9. With this it reboots successfully without
> requiring a command-line option. Note that the EFI code forces
> reboot_type to BOOT_EFI when the machine is booted via EFI, but this
> overrides that since the core_initcall runs after the EFI
> initialization code.
>

MacBookPro5,1 has also this problem. I booted with reboot=pci on
2.6.30.4 and now it rebooted without problem.
That would be nice if you could add another quirk entry for it:

System Information
Manufacturer: Apple Inc.
Product Name: MacBookPro5,1

Thanks!
Ozan Caglayan