From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755442AbZHDMhL (ORCPT ); Tue, 4 Aug 2009 08:37:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755425AbZHDMhL (ORCPT ); Tue, 4 Aug 2009 08:37:11 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54386 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755267AbZHDMhK (ORCPT ); Tue, 4 Aug 2009 08:37:10 -0400 Message-ID: <4A782C61.4030809@redhat.com> Date: Tue, 04 Aug 2009 15:41:05 +0300 From: Izik Eidus User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: Hugh Dickins CC: Andrea Arcangeli , Rik van Riel , Chris Wright , Nick Piggin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/12] ksm: five little cleanups References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hugh Dickins wrote: > 1. We don't use __break_cow entry point now: merge it into break_cow. > 2. remove_all_slot_rmap_items is just a special case of > remove_trailing_rmap_items: use the latter instead. > 3. Extend comment on unmerge_ksm_pages and rmap_items. > 4. try_to_merge_two_pages should use try_to_merge_with_ksm_page > instead of duplicating its code; and so swap them around. > 5. Comment on cmp_and_merge_page described last year's: update it. > > Signed-off-by: Hugh Dickins > --- > > > Acked-by: Izik Eidus