From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755244AbZHDTbn (ORCPT ); Tue, 4 Aug 2009 15:31:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755086AbZHDTbn (ORCPT ); Tue, 4 Aug 2009 15:31:43 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44530 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754903AbZHDTbl (ORCPT ); Tue, 4 Aug 2009 15:31:41 -0400 Message-ID: <4A788D95.9070107@redhat.com> Date: Tue, 04 Aug 2009 22:35:49 +0300 From: Izik Eidus User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: Hugh Dickins CC: Andrea Arcangeli , Rik van Riel , Chris Wright , Nick Piggin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 12/12] ksm: remove VM_MERGEABLE_FLAGS References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hugh Dickins wrote: > KSM originally stood for Kernel Shared Memory: but the kernel has long > supported shared memory, and VM_SHARED and VM_MAYSHARE vmas, and KSM is > something else. So we switched to saying "merge" instead of "share". > > But Chris Wright points out that this is confusing where mmap.c merges > adjacent vmas: most especially in the name VM_MERGEABLE_FLAGS, used by > is_mergeable_vma() to let vmas be merged despite flags being different. > > Call it VMA_MERGE_DESPITE_FLAGS? Perhaps, but at present it consists > only of VM_CAN_NONLINEAR: so for now it's clearer on all sides to use > that directly, with a comment on it in is_mergeable_vma(). > > Signed-off-by: Hugh Dickins > --- > Acked-by: Izik Eidus