From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964816AbZHERAG (ORCPT ); Wed, 5 Aug 2009 13:00:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934694AbZHERAF (ORCPT ); Wed, 5 Aug 2009 13:00:05 -0400 Received: from hera.kernel.org ([140.211.167.34]:55629 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934675AbZHERAE (ORCPT ); Wed, 5 Aug 2009 13:00:04 -0400 Message-ID: <4A79BB04.8000408@kernel.org> Date: Thu, 06 Aug 2009 02:01:56 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.22 (X11/20090605) MIME-Version: 1.0 To: Greg KH CC: Al Viro , Takashi Iwai , Linux Kernel , cguthrie@mandriva.org Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev() References: <4A79283E.7030202@kernel.org> <20090805161643.GA28436@kroah.com> <4A79B3A6.7090109@kernel.org> <20090805164919.GA27457@kroah.com> In-Reply-To: <20090805164919.GA27457@kroah.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Wed, 05 Aug 2009 16:59:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg KH wrote: > On Thu, Aug 06, 2009 at 01:30:30AM +0900, Tejun Heo wrote: >> Greg KH wrote: >>> On Wed, Aug 05, 2009 at 03:35:42PM +0900, Tejun Heo wrote: >>>> [un]register_chrdev() assume minor range 0-255. This patch adds __ >>>> prefixed versions which take @minorbase and @count explicitly. >>> What's the difference between this and the existing >>> register_chrdev_region() function? Why doesn't that work for you? >>> >>> What am I missing here? >> The function names in char_dev.c are quite confusing. > > That's an understatement :) Yeah, it sure is. It should have used a different verb at the very least. >> register_chrdev_region() only registers chrdev region. >> register_chrdev() registers chrdev region and creates a cdev for the >> region. :-) > > Yes, but you can use register_chrdev_region() and then call cdev_alloc() > for the specific cdevs you need, right? It's not the prettiest, but it > should work. Yeap, I can. That's basically what register_chrdev() is. If it had a better name, adding a new variant would have been much nicer. Having the helper makes sense tho. Names too confusing? Thanks. -- tejun