Re: [PATCH v2] add SBC-FITPC2 watchdog driver

[Denis Turischev <denis@compulab.co.il>]

Thanks Wim,

Tested, seems ok.

Denis

Wim Van Sebroeck wrote:
> Hi Mike, Denis,
>
>   
>>> From: Denis Turischev <denis@compulab.co.il>
>>>       
>> This patch adds support for watchdog found on SBC-FITPC2 board.
>>
>> --
>> v2 changes:
>> - reorder fitpc2_wdt_write to reduce the indent
>> - change printk levels
>> - use pr_fmt
>> - add release_region in the _init error path
>>
>> Signed-off-by: Denis Turischev <denis@compulab.co.il>
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>>     
>
> Some remarks:
> 1) If you dou request_regions in the init section then you need to do release_regions also in the exit section.
> 2) we prefer:
>  static long wdt_ioctl(parameters
> 			rest_of_parameters)
> instead of
>  static long
>  wdt_ioctl(parameters)
> 3) misc_deregister can return with an error. If it does you need to do the release_regions also.
> 4) as Andrew allready pointed out spinlock needs to be initialized.
> 5) if you don't use the reboot_notifier then you don't need to include linux/notifier.h and linux/reboot.h .
>
> I adapted the code.
> Can you test the attached diff?
>
> Thanks in advance,
> Wim.
>
>