public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ozan Çağlayan" <ozan@pardus.org.tr>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] markup_oops: Use modinfo to avoid confusion with underscored module names
Date: Thu, 06 Aug 2009 18:32:12 +0300	[thread overview]
Message-ID: <4A7AF77C.3070204@pardus.org.tr> (raw)
In-Reply-To: <20090806071129.3e5603ef@infradead.org>

Arjan van de Ven wrote:
> On Thu,  6 Aug 2009 15:21:55 +0300
> Ozan Çağlayan <ozan@pardus.org.tr> wrote:
>
>   
>> When EIP is at a module having an underscore in its name, the current
>> code fails to find it because the module filenames has '-' instead of
>> '_'.
>>
>> Use modinfo to correctly get the full path to the module.
>>
>> Signed-off-by: Ozan Çağlayan <ozan@pardus.org.tr>
>>     
>
> I like it, it's simple.
> I don't mind about the module-init-tools dependency, everyone will have
> that already.
>   

BTW, note that the old code was searching for *.ko files in
dirname($vmlinux_name). Replacing it by modprobe will eventually always
search for the modules in /lib/modules/KVER/.

  reply	other threads:[~2009-08-06 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 12:21 [PATCH] markup_oops: Use modinfo to avoid confusion with underscored module names Ozan Çağlayan
2009-08-06 14:11 ` Arjan van de Ven
2009-08-06 15:32   ` Ozan Çağlayan [this message]
2009-08-07  1:42 ` Amerigo Wang
2009-08-10  9:13 ` [PATCH v2] " Ozan Çağlayan
2009-08-10 14:37   ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7AF77C.3070204@pardus.org.tr \
    --to=ozan@pardus.org.tr \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox